Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391933005: Elim defaultBrowser from settings on chromeos (Closed)

Created:
5 years, 2 months ago by stevenjb
Modified:
5 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim defaultBrowser from settings on chromeos BUG=536295 Committed: https://crrev.com/f718a953c232d790754d267d5135c2b2b1f7fbe5 Cr-Commit-Position: refs/heads/master@{#353831}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M chrome/browser/resources/settings/basic_page/basic_page.html View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
It turns out we shouldn't include defaultBrowser in chrome os at all.
5 years, 2 months ago (2015-10-13 17:31:36 UTC) #2
dschuyler
lgtm
5 years, 2 months ago (2015-10-13 17:34:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391933005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391933005/20001
5 years, 2 months ago (2015-10-13 18:09:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 20:09:11 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 20:10:00 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f718a953c232d790754d267d5135c2b2b1f7fbe5
Cr-Commit-Position: refs/heads/master@{#353831}

Powered by Google App Engine
This is Rietveld 408576698