third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h - Issue 1391933004: [Tracing] Add hook to PartitionAlloc for heap profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h

Issue 1391933004: [Tracing] Add hook to PartitionAlloc for heap profiling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_memory_dump_provider_adapter.cc ('K') | « content/child/web_memory_dump_provider_adapter.cc ('k') | third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp » ('j') | third_party/WebKit/Source/wtf/PartitionAlloc.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h

diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h

index 2e56e9b0ab88a1755ae2f8d727eeccd738d92dc7..5d62b6bc7401d6c0ce41c3f166e545dd843c4973 100644

--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h

+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h

@@ -17,6 +17,8 @@ public:

// WebMemoryDumpProvider implementation.

bool onMemoryDump(WebMemoryDumpLevelOfDetail, WebProcessMemoryDump*) override;

+ bool supportsHeapProfiling() override { return true; }

Primiano Tucci (use gerrit) 2015/10/12 16:36:45 isn't clang going to be unhappy about inline virtu

Ruud van Asseldonk 2015/10/13 10:42:18 I did not hear it complain.

+ void onHeapProfilingEnabled(AllocationHook*, FreeHook*) override;

private:

PartitionAllocMemoryDumpProvider();