Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1391933002: Restrict memory maps dump provider to only android and linux (Closed)

Created:
5 years, 2 months ago by ssid
Modified:
5 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@smaps_fscan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict memory maps dump provider to only android and linux The memory maps dump provider is used only in android and linux, and not yet supported in windows. So, this should be compiled only in linux and android. BUG=461788 Committed: https://crrev.com/cf0bd979e8594b8fe369ed3177038cb06c05f05b Cr-Commit-Position: refs/heads/master@{#353029}

Patch Set 1 #

Patch Set 2 : Fix nacl. #

Total comments: 1

Patch Set 3 : build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M base/trace_event/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.cc View 1 2 4 chunks +1 line, -8 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M base/trace_event/trace_event.gypi View 3 chunks +12 lines, -10 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
ssid
PTAL, thanks
5 years, 2 months ago (2015-10-07 14:07:25 UTC) #2
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1391933002/diff/20001/base/base.gypi File base/base.gypi (right): https://codereview.chromium.org/1391933002/diff/20001/base/base.gypi#newcode826 base/base.gypi:826: 'trace_event/process_memory_maps_dump_provider.cc', why this change in base.gypi?
5 years, 2 months ago (2015-10-07 16:35:49 UTC) #3
ssid
The nacl variable still did not work. I got other build errors. Finally I decided ...
5 years, 2 months ago (2015-10-08 09:28:33 UTC) #4
Primiano Tucci (use gerrit)
LGTM
5 years, 2 months ago (2015-10-08 09:32:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391933002/40001
5 years, 2 months ago (2015-10-08 09:36:15 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 09:46:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391933002/40001
5 years, 2 months ago (2015-10-08 10:08:29 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 10:22:19 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 10:23:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf0bd979e8594b8fe369ed3177038cb06c05f05b
Cr-Commit-Position: refs/heads/master@{#353029}

Powered by Google App Engine
This is Rietveld 408576698