Declaration of sha1HashSize variable in proper file

Redeclared the sha1HashSize variable in Webkit/Source/wtf/SHA1.h instead of WebKit/Source/modules/websockets/WebSocketHandshake.cpp

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168781

[Sunil Ratnu, 2014-01-15 08:13:59]

Please review my change.

[eseidel, 2014-01-15 08:21:49]

I don't understand what this is trying to do.  Why is sha1 hash size always 20?

[Sunil Ratnu, 2014-01-15 11:25:45]

On 2014/01/15 08:21:49, eseidel wrote:
> I don't understand what this is trying to do.  Why is sha1 hash size always
20?

Thanks Eric. 
According to Secure Hash Standard by NIST, th SHA-1 may be used to hash a
message but the final result is always a 160-bit message digest. Hence the hash
size is always 20.

Reference Link : http://csrc.nist.gov/publications/fips/fips180-4/fips-180-4.pdf

[eseidel, 2014-01-22 21:33:30]

Sorry, I'm not the correct reviewer for this.

[abarth-chromium, 2014-01-22 21:34:28]

I don't think this change is worth making.

[eroman, 2014-01-22 21:37:25]

This looks fine to me, however I would use a more descriptive name for the
constant (in particular, suffixing either "bytes" or "bits"). For instance:

  SHA1::OutputSizeBytes
or
  SHA1::DigestSizeBytes

[Sunil Ratnu, 2014-01-23 07:25:04]

On 2014/01/22 21:37:25, eroman wrote:
> This looks fine to me, however I would use a more descriptive name for the
> constant (in particular, suffixing either "bytes" or "bits"). For instance:
> 
>   SHA1::OutputSizeBytes
> or
>   SHA1::DigestSizeBytes

Thank you all for the review.
Made required changes suggested by eroman.

[eroman, 2014-01-31 03:33:59]

L G T M, however must defer to the module owners.

[eseidel, 2014-01-31 04:09:30]

lgtm

[commit-bot: I haz the power, 2014-01-31 04:09:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/139193002/150001

[eseidel, 2014-01-31 04:11:32]

Actually, not lgtm.  The only CLA signer we have named "sunil" from samsung is
sunim, which appears to be a different person.

We have to go through this first:
http://dev.chromium.org/developers/contributing-code/external-contributor-che...

[commit-bot: I haz the power, 2014-01-31 04:11:40]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 04:11:44]

CQ bit was unchecked on CL. Ignoring.

[Sunil Ratnu, 2014-02-05 05:42:03]

On 2014/01/31 04:11:44, I haz the power (commit-bot) wrote:
> CQ bit was unchecked on CL. Ignoring.

@eseidel: We have done necessary requirements from our side for CLA. You might
be able to see my name now.

[Sunil Ratnu, 2014-03-05 19:34:47]

On 2014/02/05 05:42:03, sunil.ratnu wrote:
> On 2014/01/31 04:11:44, I haz the power (commit-bot) wrote:
> > CQ bit was unchecked on CL. Ignoring.
> 
> @eseidel: We have done necessary requirements from our side for CLA. You might
> be able to see my name now.

Hi Eric,
Please have a look at it. Thanks!

[eseidel, 2014-03-05 21:31:38]

lgtm

[commit-bot: I haz the power, 2014-03-05 21:32:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/139193002/150001

[commit-bot: I haz the power, 2014-03-05 21:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:33:59]

Try jobs failed on following builders: mac_blink_compile

[Sunil Ratnu, 2014-03-08 12:00:45]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-08 12:00:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/139193002/150001

[commit-bot: I haz the power, 2014-03-08 12:19:16]

Change committed as 168781