Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1391903002: [turbofan] Separate JSInliningHeuristic into own class. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Separate JSInliningHeuristic into own class. This separates the core machinery and the heuristics involved with inlining functions calls. So far the heuristic only respects our %SetForceInlineFlag hint, but it will the place where general inlining heuristics can live without impeding clarity of the core machinery. R=bmeurer@chromium.org Committed: https://crrev.com/0a6863f029e5afaf6ea97a9b27087307b8b65b45 Cr-Commit-Position: refs/heads/master@{#31150}

Patch Set 1 #

Patch Set 2 : Fix GN build. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -17 lines) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +9 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +10 lines, -6 lines 0 comments Download
A src/compiler/js-inlining-heuristic.h View 1 chunk +34 lines, -0 lines 0 comments Download
A src/compiler/js-inlining-heuristic.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-07 10:51:06 UTC) #1
Benedikt Meurer
LGTM, nice.
5 years, 2 months ago (2015-10-07 12:13:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391903002/40001
5 years, 2 months ago (2015-10-07 12:17:13 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-07 12:18:25 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 12:18:45 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a6863f029e5afaf6ea97a9b27087307b8b65b45
Cr-Commit-Position: refs/heads/master@{#31150}

Powered by Google App Engine
This is Rietveld 408576698