Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: content/browser/browser_main_loop.cc

Issue 1391893003: NOT FOR REVIEW: Aura on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index e5ee0cfc3ae607054efc2437abbda88c43ac6914..60d0dbb2f1a7499c760510855706b7459fb530a3 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -583,7 +583,7 @@ void BrowserMainLoop::PostMainMessageLoopStart() {
}
#endif // !defined(OS_IOS)
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
{
TRACE_EVENT0("startup", "BrowserMainLoop::Subsystem:SurfaceTextureManager");
no sievers 2015/10/20 19:24:22 keep this
if (parsed_command_line_.HasSwitch(switches::kSingleProcess)) {
@@ -743,13 +743,13 @@ void BrowserMainLoop::CreateStartupTasks() {
&BrowserMainLoop::PreMainMessageLoopRun, base::Unretained(this));
startup_task_runner_->AddTask(pre_main_message_loop_run);
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID)// && !defined(USE_AURA)
if (BrowserMayStartAsynchronously()) {
startup_task_runner_->StartRunningTasksAsync();
}
#endif
}
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID)// && !defined(USE_AURA)
if (!BrowserMayStartAsynchronously()) {
// A second request for asynchronous startup can be ignored, so
// StartupRunningTasksAsync is only called first time through. If, however,
@@ -1128,7 +1128,9 @@ int BrowserMainLoop::BrowserThreadsStarted() {
bool always_uses_gpu = true;
bool established_gpu_channel = false;
-#if defined(OS_ANDROID)
+ // TODO(mfomitchev): Need ImageTransportFactory::Initialize on Android Aura,
+ // but figure out what to do with BrowserGpuChannelHostFactory.
no sievers 2015/10/20 19:24:22 We can try to do BrowserGpuChannelHostFactory::Ini
+#if defined(OS_ANDROID) && !defined(USE_AURA)
// TODO(crbug.com/439322): This should be set to |true|.
established_gpu_channel = false;
BrowserGpuChannelHostFactory::Initialize(established_gpu_channel);
@@ -1324,7 +1326,7 @@ base::FilePath BrowserMainLoop::GetStartupTraceFileName(
return trace_file;
if (trace_file.empty()) {
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
no sievers 2015/10/20 19:24:22 TODO: tracing
TracingControllerAndroid::GenerateTracingFilePath(&trace_file);
#else
// Default to saving the startup trace into the current dir.

Powered by Google App Engine
This is Rietveld 408576698