Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6551)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1391893003: NOT FOR REVIEW: Aura on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 669b84e44ee92fa57fc7e7a1b1b72c036fd838b0..d4e83a91ccdbb51c60c0dab1952364953f5c49a1 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -149,13 +149,16 @@
#include "ui/strings/grit/app_locale_settings.h"
#if defined(OS_ANDROID)
+#include "ui/base/resource/resource_bundle_android.h"
+#endif // defined(OS_ANDROID)
+
+#if defined(OS_ANDROID) && !defined(USE_AURA)
#include "chrome/browser/android/dev_tools_discovery_provider_android.h"
#include "chrome/browser/metrics/thread_watcher_android.h"
-#include "ui/base/resource/resource_bundle_android.h"
#else
#include "chrome/browser/devtools/chrome_devtools_discovery_provider.h"
#include "chrome/browser/feedback/feedback_profile_observer.h"
-#endif // defined(OS_ANDROID)
+#endif // defined(OS_ANDROID) && !defined(USE_AURA)
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
#include "chrome/browser/first_run/upgrade_util_linux.h"
@@ -248,7 +251,7 @@ void HandleTestParameters(const base::CommandLine& command_line) {
}
}
-#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+#if (!defined(OS_ANDROID)/* || defined(USE_AURA)*/) && !defined(OS_CHROMEOS)
void AddFirstRunNewTabs(StartupBrowserCreator* browser_creator,
const std::vector<GURL>& new_tabs) {
for (std::vector<GURL>::const_iterator it = new_tabs.begin();
@@ -808,11 +811,11 @@ int ChromeBrowserMainParts::PreCreateThreads() {
result_code_ = PreCreateThreadsImpl();
if (result_code_ == content::RESULT_CODE_NORMAL_EXIT) {
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
// These members must be initialized before exiting this function normally.
DCHECK(master_prefs_.get());
DCHECK(browser_creator_.get());
-#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) || defined(USE_AURA)
for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
chrome_extra_parts_[i]->PreCreateThreads();
}
@@ -870,14 +873,14 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
local_state_ = InitializeLocalState(
local_state_task_runner.get(), parsed_command_line());
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
// These members must be initialized before returning from this function.
master_prefs_.reset(new first_run::MasterPrefs);
// Android doesn't use StartupBrowserCreator.
browser_creator_.reset(new StartupBrowserCreator);
// TODO(yfriedman): Refactor Android to re-use UMABrowsingActivityObserver
chrome::UMABrowsingActivityObserver::Init();
-#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) || defined(USE_AURA)
#if !defined(OS_CHROMEOS)
// Convert active labs into switches. This needs to be done before
@@ -939,7 +942,7 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
"ChromeBrowserMainParts::PreCreateThreadsImpl:AddDataPack");
base::FilePath resources_pack_path;
PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) // we do want to use this - even with Aura
ui::LoadMainAndroidPackFile("assets/resources.pak", resources_pack_path);
#else
ResourceBundle::GetSharedInstance().AddDataPackFromPath(
@@ -950,7 +953,7 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
// Android does first run in Java instead of native.
// Chrome OS has its own out-of-box-experience code.
-#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+#if (!defined(OS_ANDROID)/* || defined(USE_AURA)*/) && !defined(OS_CHROMEOS)
// On first run, we need to process the predictor preferences before the
// browser's profile_manager object is created, but after ResourceBundle
// is initialized.
@@ -1096,11 +1099,11 @@ void ChromeBrowserMainParts::PreProfileInit() {
void ChromeBrowserMainParts::PostProfileInit() {
TRACE_EVENT0("startup", "ChromeBrowserMainParts::PostProfileInit");
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
DevToolsDiscoveryProviderAndroid::Install();
#else
ChromeDevToolsDiscoveryProvider::Install();
-#endif // defined(OS_ANDROID)
+#endif // defined(OS_ANDROID) && !defined(USE_AURA)
LaunchDevToolsHandlerIfNeeded(parsed_command_line());
for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
@@ -1371,12 +1374,12 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
if (!profile_)
return content::RESULT_CODE_NORMAL_EXIT;
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
const base::TimeTicks start_time_step2 = base::TimeTicks::Now();
// The first run sentinel must be created after the process singleton was
// grabbed and no early return paths were otherwise hit above.
first_run::CreateSentinelIfNeeded();
-#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) || defined(USE_AURA)
#if defined(ENABLE_BACKGROUND)
// Autoload any profiles which are running background apps.
@@ -1549,9 +1552,9 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
g_browser_process->local_state());
ThreadWatcherList::StartWatchingAll(parsed_command_line());
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
ThreadWatcherAndroid::RegisterApplicationStatusListener();
-#endif // defined(OS_ANDROID)
+#endif // defined(OS_ANDROID) && !defined(USE_AURA)
#if !defined(DISABLE_NACL)
BrowserThread::PostTask(
@@ -1578,7 +1581,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate))
RegisterComponentsForUpdate();
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
chrome_variations::VariationsService* variations_service =
browser_process_->variations_service();
if (variations_service) {
@@ -1674,9 +1677,11 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
content::StartPowerUsageMonitor();
#endif // !defined(OS_LINUX) || defined(OS_CHROMEOS)
+#if !defined(OS_ANDROID)
process_power_collector_.reset(new ProcessPowerCollector);
process_power_collector_->Initialize();
#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) && !defined(USE_AURA)
PostBrowserStart();
@@ -1694,10 +1699,10 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
}
#endif // defined(OS_ANDROID)
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) || defined(USE_AURA)
UMA_HISTOGRAM_TIMES("Startup.PreMainMessageLoopRunImplStep3Time",
base::TimeTicks::Now() - start_time_step3);
-#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) || defined(USE_AURA)
return result_code_;
}

Powered by Google App Engine
This is Rietveld 408576698