Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: content/renderer/render_widget.cc

Issue 1391843006: Embed keyboard shortcut bit in WebKeyboardEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mac test compile Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 081f0832fcadeb0e234088a01822491d8835df50..e42f2b47de5ce6574e111f0309e3e3c64d65a346 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1044,8 +1044,7 @@ void RenderWidget::OnSwapBuffersComplete() {
}
void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
- const ui::LatencyInfo& latency_info,
- bool is_keyboard_shortcut) {
+ const ui::LatencyInfo& latency_info) {
if (!input_event)
return;
base::AutoReset<bool> handling_input_event_resetter(&handling_input_event_,
@@ -1157,6 +1156,9 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
// If this RawKeyDown event corresponds to a browser keyboard shortcut and
// it's not processed by webkit, then we need to suppress the upcoming Char
// events.
+ bool is_keyboard_shortcut =
+ input_event->type == WebInputEvent::RawKeyDown &&
+ static_cast<const WebKeyboardEvent*>(input_event)->isBrowserShortcut;
if (!processed && is_keyboard_shortcut)
suppress_next_char_events_ = true;
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698