Embed keyboard shortcut bit in WebKeyboardEvent

Embed keyboard shortcut bit in WebKeyboardEvent

Before a WebKeyboardEvent is forwarded to the renderer, the content
embedder can tag it as a keyboard shortcut. This shortcut bit is passed
along with the input event to the renderer, allowing the renderer to
suppress follow-up Char events for unhandled RawKeyDown events that are
part of a keyboard shortcut.

However, passing around this keyboard shortcut bit separately is awkward
and pollutes a number of input-related methods. Instead, just embed the
shortcut bit directly in the WebKeyboardEvent.

BUG=302492
Committed: https://crrev.com/0cf1e6644924c89bc2fcb288f45e59cf2612c63c
Cr-Commit-Position: refs/heads/master@{#354384}

[jdduke (slow), 2015-10-09 21:29:54]

jdduke@chromium.org changed reviewers:
+ tdresser@chromium.org

[jdduke (slow), 2015-10-09 21:29:55]

tdresser@: Thoughts? Was working on some other stuff and realized this has
always bothered me.

[jdduke (slow), 2015-10-09 21:30:26]

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
content/browser/renderer_host/render_widget_host_impl.cc:1148:
key_event_with_latency.event.isBrowserShortcut = is_shortcut;
This is the critical change, the rest is really just cleanup.

[tdresser, 2015-10-13 13:19:48]

LGTM!

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
File content/browser/renderer_host/render_widget_host_unittest.cc (right):

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
content/browser/renderer_host/render_widget_host_unittest.cc:914: // Simluate
the situation that the browser handled the key down event during
Simluate -> Simulate

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
content/browser/renderer_host/render_widget_host_unittest.cc:956: // Simluate
the situation that the browser marks the key down as a keyboard
Simluate -> Simulate

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/renderer...
File content/renderer/render_widget.cc (right):

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/renderer...
content/renderer/render_widget.cc:1159: if (!processed && input_event->type ==
WebInputEvent::RawKeyDown &&
I have a slight preference for:

bool is_keyboard_shortcut = input_event->type == WebInputEvent::RawKeyDown &&
static_cast<const WebKeyboardEvent*>(input_event)->isBrowserShortcut;

if (!processed && is_keyboard_shortcut)

[jdduke (slow), 2015-10-13 16:13:02]

jdduke@chromium.org changed reviewers:
+ rbyers@chromium.org, sievers@chromium.org

[jdduke (slow), 2015-10-13 16:13:03]

+sievers for content/ rubberstamp.
+rbyers for WebKit/public.

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
File content/browser/renderer_host/render_widget_host_unittest.cc (right):

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
content/browser/renderer_host/render_widget_host_unittest.cc:914: // Simluate
the situation that the browser handled the key down event during
On 2015/10/13 13:19:47, tdresser wrote:
> Simluate -> Simulate

Done.

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/browser/...
content/browser/renderer_host/render_widget_host_unittest.cc:956: // Simluate
the situation that the browser marks the key down as a keyboard
On 2015/10/13 13:19:47, tdresser wrote:
> Simluate -> Simulate

Done.

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/renderer...
File content/renderer/render_widget.cc (right):

https://chromiumcodereview.appspot.com/1391843006/diff/20001/content/renderer...
content/renderer/render_widget.cc:1159: if (!processed && input_event->type ==
WebInputEvent::RawKeyDown &&
On 2015/10/13 13:19:47, tdresser wrote:
> I have a slight preference for:
> 
> bool is_keyboard_shortcut = input_event->type == WebInputEvent::RawKeyDown &&
> static_cast<const WebKeyboardEvent*>(input_event)->isBrowserShortcut;
> 
> if (!processed && is_keyboard_shortcut)

Done.

[no sievers, 2015-10-13 18:41:27]

lgtm

[jdduke (slow), 2015-10-13 18:45:18]

jdduke@chromium.org changed reviewers:
+ tsepez@chromium.org

[jdduke (slow), 2015-10-13 18:45:19]

+tsepez for (trivial) content/common/input_messages.h changes.

[Tom Sepez, 2015-10-13 19:14:48]

Trivial LGTM.

[jdduke (slow), 2015-10-15 14:57:23]

On 2015/10/13 16:13:03, jdduke wrote:
> +rbyers for WebKit/public.

Rick, anything else you'd like to see here?

[Rick Byers, 2015-10-15 21:22:34]

On 2015/10/15 14:57:23, jdduke wrote:
> On 2015/10/13 16:13:03, jdduke wrote:
> > +rbyers for WebKit/public.
> 
> Rick, anything else you'd like to see here?

Nope, sorry for the delay.  LGTM also.

[jdduke (slow), 2015-10-15 21:25:33]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-10-15 21:25:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, tsepez@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1391843006/#ps60001
(title: "Fix mac test compile")

[commit-bot: I haz the power, 2015-10-15 21:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1391843006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1391843006/60001

[commit-bot: I haz the power, 2015-10-15 22:43:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-15 22:44:28]

Patchset 4 (id:??) landed as
https://crrev.com/0cf1e6644924c89bc2fcb288f45e59cf2612c63c
Cr-Commit-Position: refs/heads/master@{#354384}