Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 139173012: Move encryptedmedia module to oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/V8DOMWrapper.h » ('j') | Source/modules/encryptedmedia/MediaKeys.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 9401eb50e0a0dbb888118f963e7177c539ad9612..5579271aa3cd2ed930b171ffbfe28f4a5bc20e3a 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -1066,16 +1066,18 @@ sub GetInternalFields
my $interface = shift;
my @customInternalFields = ();
- # If we have persistentHandleIndex, it should be at the first index of the custom
- # internal fileds.
- if (IsWillBeGarbageCollectedType($interface->name)) {
- push(@customInternalFields, "persistentHandleIndex");
- }
# Event listeners on DOM nodes are explicitly supported in the GC controller.
if (!InheritsInterface($interface, "Node") &&
InheritsInterface($interface, "EventTarget")) {
push(@customInternalFields, "eventListenerCacheIndex");
}
+ # Persistent handle is stored in the last internal field.
+ # FIXME: Remove this internal field. Since we need either of a persistent handle
+ # (if the object is in oilpan) or a C++ pointer to the DOM object (if the object is not in oilpan),
+ # we can share the internal field between the two cases.
+ if (IsWillBeGarbageCollectedType($interface->name)) {
+ push(@customInternalFields, "persistentHandleIndex");
+ }
return @customInternalFields;
}
« no previous file with comments | « no previous file | Source/bindings/v8/V8DOMWrapper.h » ('j') | Source/modules/encryptedmedia/MediaKeys.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698