Chromium Code Reviews| Index: Source/bindings/scripts/code_generator_v8.pm |
| diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm |
| index b5ef7bf42f6c4bd5d149069cb65a78f8fa7e64f4..3155754c513519a2bf2ff566769231990cf17d46 100644 |
| --- a/Source/bindings/scripts/code_generator_v8.pm |
| +++ b/Source/bindings/scripts/code_generator_v8.pm |
| @@ -1066,16 +1066,18 @@ sub GetInternalFields |
| my $interface = shift; |
| my @customInternalFields = (); |
| - # If we have persistentHandleIndex, it should be at the first index of the custom |
| - # internal fileds. |
| - if (IsWillBeGarbageCollectedType($interface->name)) { |
| - push(@customInternalFields, "persistentHandleIndex"); |
| - } |
| # Event listeners on DOM nodes are explicitly supported in the GC controller. |
| if (!InheritsInterface($interface, "Node") && |
| InheritsInterface($interface, "EventTarget")) { |
| push(@customInternalFields, "eventListenerCacheIndex"); |
| } |
| + # Persistent handle is stored in the last internal field. |
|
haraken
2014/02/07 04:25:01
Please look at the CL description if you wonder wh
|
| + # FIXME: Remove this internal field. Since we need either of a persistent handle |
| + # (if the object is in oilpan) or a C++ pointer to the DOM object (if the object is not in oilpan), |
| + # we can share the internal field between the two cases. |
| + if (IsWillBeGarbageCollectedType($interface->name)) { |
| + push(@customInternalFields, "persistentHandleIndex"); |
| + } |
| return @customInternalFields; |
| } |