cc/base/math_util.cc - Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/math_util.cc

Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT and fixed build error for Android platform! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/base/math_util.cc

diff --git a/cc/base/math_util.cc b/cc/base/math_util.cc

index 0cc120d89094c818e72f6480711c6e3a5ed1e99a..23a96275c9fed62a71cf98ecff1d5160aedc35ce 100644

--- a/cc/base/math_util.cc

+++ b/cc/base/math_util.cc

@@ -514,7 +514,7 @@ scoped_ptr<base::Value> MathUtil::AsValue(gfx::Size s) {

return res.PassAs<base::Value>();

}

-scoped_ptr<base::Value> MathUtil::AsValue(gfx::SizeF s) {

+scoped_ptr<base::Value> MathUtil::AsValue(const gfx::SizeF& s) {

scoped_ptr<base::DictionaryValue> res(new base::DictionaryValue());

res->SetDouble("width", s.width());

res->SetDouble("height", s.height());

« no previous file with comments | « cc/base/math_util.h ('k') | cc/input/layer_scroll_offset_delegate.h » ('j') | no next file with comments »