Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391653002: Remove ClipMaskType from GrCMM (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cfp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -33 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 2 chunks +0 lines, -19 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 9 chunks +1 line, -14 lines 0 comments Download

Depends on Patchset:

Issue 1393553002 Patch 60001

Messages

Total messages: 9 (3 generated)
bsalomon
This is a hold-over from when clipping was applied by GrGpu
5 years, 2 months ago (2015-10-06 19:15:50 UTC) #2
bsalomon
+Rob
5 years, 2 months ago (2015-10-07 16:14:04 UTC) #4
egdaniel
lgtm
5 years, 2 months ago (2015-10-07 16:15:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391653002/20001
5 years, 2 months ago (2015-10-07 16:22:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/c988d2c1c840689e89a7bbcf39cf10ff818708ae
5 years, 2 months ago (2015-10-07 16:30:09 UTC) #8
robertphillips
5 years, 2 months ago (2015-10-07 18:17:48 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698