Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1391643003: [es6] ship @@isConcatSpreadable (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] ship @@isConcatSpreadable As discussed, shipping early in the M48 branch will likely have greater exposure than staging, in order to find any remaining bugs with this feature, and provides plenty of time to unship if needed. BUG= LOG=N R=adamk@chromium.org, wingo@chromium.org, rossberg@chromium.org Committed: https://crrev.com/874549c79cd5f16bd997d0dfd5ee0301b052b0de Cr-Commit-Position: refs/heads/master@{#31132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
caitp (gmail)
See CL description for reasoning. I don't know if this is how we want to ...
5 years, 2 months ago (2015-10-06 19:05:48 UTC) #1
adamk
lgtm This seems fine to me.
5 years, 2 months ago (2015-10-06 19:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391643003/1
5 years, 2 months ago (2015-10-06 19:31:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 19:56:39 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 19:57:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/874549c79cd5f16bd997d0dfd5ee0301b052b0de
Cr-Commit-Position: refs/heads/master@{#31132}

Powered by Google App Engine
This is Rietveld 408576698