Issue 13916004: Translate 1 pixel not 1 dip when rotating the display.

Issue 13916004: Translate 1 pixel not 1 dip when rotating the display. (Closed)

Created:
7 years, 8 months ago by oshima

Modified:
7 years, 8 months ago

Reviewers:
Jun Mukai, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Translate 1 pixel not 1 dip when rotating the display. BUG=222483 TEST=covered by unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193560

Patch Set 2 : remove chromeos specific test that is no longer necessary #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -94 lines)			Patch
M	ash/display/display_controller.cc	View	1	1 chunk	+11 lines, -9 lines	0 comments	Download
M	ash/display/display_controller_unittest.cc	View		7 chunks	+42 lines, -25 lines	0 comments	Download
M	ui/aura/root_window.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

https://codereview.chromium.org/13916004/diff/5001/ui/aura/root_window.cc File ui/aura/root_window.cc (left): https://codereview.chromium.org/13916004/diff/5001/ui/aura/root_window.cc#oldcode695 ui/aura/root_window.cc:695: #if defined(OS_CHROMEOS) don't forget the #include from the other ...

7 years, 8 months ago (2013-04-11 00:17:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/13916004/5001

7 years, 8 months ago (2013-04-11 00:20:12 UTC) #6

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) aura_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=102085

7 years, 8 months ago (2013-04-11 01:22:03 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/13916004/25001

7 years, 8 months ago (2013-04-11 01:35:21 UTC) #8

Message was sent while issue was closed.

Change committed as 193560

Expand Messages | Collapse Messages