Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1391583004: Blacklist rooksbas.dll in sandboxed processes (Closed)

Created:
5 years, 2 months ago by jschuh
Modified:
5 years, 2 months ago
Reviewers:
scottmg
CC:
chrome-blacklisting-announce_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklist rooksbas.dll in sandboxed processes This is a huge source of crashes and hangs. The below bug is representative. Query crash for a longer list BUG=537647 R=scottmg@chromium.org Committed: https://crrev.com/bccf4d75f7e9eaa4cc0f0aa0ff223e2e9f3b71e1 Cr-Commit-Position: refs/heads/master@{#352723}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Patch Set 3 : x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/common/sandbox_win.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jschuh
ptal
5 years, 2 months ago (2015-10-06 20:50:42 UTC) #1
scottmg
lgtm https://codereview.chromium.org/1391583004/diff/1/content/common/sandbox_win.cc File content/common/sandbox_win.cc (right): https://codereview.chromium.org/1391583004/diff/1/content/common/sandbox_win.cc#newcode107 content/common/sandbox_win.cc:107: L"rooksbas.dll", // IBM Trusteer Rapport all the rest ...
5 years, 2 months ago (2015-10-06 20:54:39 UTC) #2
scottmg
LGTM!
5 years, 2 months ago (2015-10-06 20:59:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391583004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391583004/20001
5 years, 2 months ago (2015-10-06 20:59:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391583004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391583004/40001
5 years, 2 months ago (2015-10-06 21:35:35 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-07 00:24:48 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 00:25:30 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bccf4d75f7e9eaa4cc0f0aa0ff223e2e9f3b71e1
Cr-Commit-Position: refs/heads/master@{#352723}

Powered by Google App Engine
This is Rietveld 408576698