Introduce "navigate" mode in Requests

third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

Index: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
index f8dd8e83067e2f04fb1cbbd42cf0b6f078f5f308..b365e4f5566aadf48712ebad2481e96eda352ad7 100644
--- a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
@@ -60,6 +60,10 @@ test(function() {
      new Request(URL, {mode: ' cors'}),
      new Request(URL, {mode: 'co rs'}),
      new Request(URL, {mode: 'CORS'}),
+     new Request(URL, {mode: 'navigate\0'}),
+     new Request(URL, {mode: ' navigate'}),
+     new Request(URL, {mode: 'navi gate'}),
+     new Request(URL, {mode: 'NAVIGATE'}),
      new Request(URL, {mode: '\0'.repeat(100000)}),
      new Request(URL, {mode: 'x'.repeat(100000)}),
      new Request(URL, {credentials: null}),
@@ -294,6 +298,15 @@ test(function() {
   }, 'Request method name throw test');
 
 test(function() {
+    assert_throws(
+        {name: 'TypeError'},
+        function() {
+            var request = new Request(URL, {mode: 'navigate'});
+        },
+        'new Request with a navigate mode should throw');
+}, 'Request mode throw test');

[Mike West, 2015/10/20 07:27:04]

I'd also like to see a test for the copy case ("If any of init's members are
present and "navigate" was copied, throw." from
https://github.com/whatwg/fetch/issues/126#issuecomment-142224197).

[shiva.jm, 2015/10/21 08:34:59]

It's bit tricky in making layout test for these case,
where Request(req, {...}) where req.mode == 'navigate',
as we discussed in https://codereview.chromium.org/1391583002/#msg13.
will add test in RequestTest.cpp, by constructing Request object
using WebServiceWorkerRequest object, which has Navigate mode filled,
and next try to construct Request object using above Request object
created and use Dictionary to fill the RequestInit and use
ASSERT_TRUE OR EXPECT_THROW to check typeError returned, will it be good ?

[hiroshige, 2015/10/30 12:57:42]

As mentioned above, creating layout tests is hard (we cannot obtain Request with
mode == 'navigate' in this CL) and perhaps test is not needed?
I expect FrameLoadRequest.h change (suggested by horo@ and removed from this CL)
will follow after this CL, and after that we might be able to add layout tests?
(not sure though)
Waiting mkwst@'s response.

[shiva.jm, 2015/11/02 12:06:19]

The change was removed from FrameLoadRequest.h, since the enum order cannot be
changed,
as it is used for collecting the user metrics of the request modes.
So you mean, we need to make that change as horo@ suggested in :
https://codereview.chromium.org/1391583002/#msg7 ?

+
+test(function() {
     var url = 'http://example.com';
     TO_BE_NORMALIZED_METHOD_NAMES.forEach(
       function(method) {