Introduce "navigate" mode in Requests

third_party/WebKit/Source/modules/fetch/FetchManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/fetch/FetchManager.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 191 matching lines @@
 void FetchManager::Loader::didReceiveResponse(unsigned long, const ResourceResponse& response, PassOwnPtr<WebDataConsumerHandle> handle)
 {
     ASSERT(handle);
 
     m_responseHttpStatusCode = response.httpStatusCode();
 
     // Recompute the tainting if the request was redirected to a different
     // origin.
     if (!SecurityOrigin::create(response.url())->isSameSchemeHostPort(m_request->origin().get())) {
         switch (m_request->mode()) {
+        case WebURLRequest::FetchRequestModeNavigate:
+            m_request->setResponseTainting(FetchRequestData::OpaqueTainting);

[horo, 2015/10/14 10:05:31]

I think this should be "ASSERT_NOT_REACHED();".

The request mode can't be "navigate" here.
The redirect mode of "navigate" request must be "manual".
When the redirect mode is manual, DocumentThreadableLoader doesn't follow the
redirect response.
So the origin of response url must be same as the request's origin.

[shiva.jm, 2015/10/14 10:59:06]

Done, had same opinion in patchset2, but miss read from git hub discussions.
shall we maintain the order of request mode enums in Request.idl same as enum
FetchRequestMode as in WebURLRequest.h ?

[hiroshige, 2015/10/15 06:37:03]

horo@,
What poses this limitation?
The current Fetch spec text doesn't seem to do.

[horo, 2015/10/15 11:43:05]

"navigate" request is created only while "Navigating across documents". 
https://html.spec.whatwg.org/multipage/browsers.html#navigating-across-documents
https://github.com/whatwg/html/commit/80f052b44f3842084221b1104d1fecb02228699a

+            break;
         case WebURLRequest::FetchRequestModeSameOrigin:
             ASSERT_NOT_REACHED();
             break;
         case WebURLRequest::FetchRequestModeNoCORS:
             m_request->setResponseTainting(FetchRequestData::OpaqueTainting);
             break;
         case WebURLRequest::FetchRequestModeCORS:
         case WebURLRequest::FetchRequestModeCORSWithForcedPreflight:
             m_request->setResponseTainting(FetchRequestData::CORSTainting);
             break;
@@ skipping 152 matching lines @@
     // "- |request|'s url's scheme is 'about'"
     // Note we don't support to call this method with |CORS flag|.
     if ((SecurityOrigin::create(m_request->url())->isSameSchemeHostPortAndSuborigin(m_request->origin().get()))
         || (m_request->url().protocolIsData() && m_request->sameOriginDataURLFlag())
         || (m_request->url().protocolIsAbout())) {
         // "The result of performing a basic fetch using request."
         performBasicFetch();
         return;
     }
 
+    // "- |request|'s mode is |navigate|"
+    if (m_request->mode() == WebURLRequest::FetchRequestModeNavigate) {
+        // "The result of performing a basic fetch using |request|."
+        performBasicFetch();
+        return;
+    }
+
     // "- |request|'s mode is |same-origin|"
     if (m_request->mode() == WebURLRequest::FetchRequestModeSameOrigin) {
         // "A network error."
         performNetworkError("Fetch API cannot load " + m_request->url().string() + ". Request mode is \"same-origin\" but the URL\'s origin is not same as the request origin " + m_request->origin()->toString() + ".");
         return;
     }
 
     // "- |request|'s mode is |no CORS|"
     if (m_request->mode() == WebURLRequest::FetchRequestModeNoCORS) {
         // "Set |request|'s response tainting to |opaque|."
@@ skipping 134 matching lines @@
     }
     if (m_request->credentials() == WebURLRequest::FetchCredentialsModeInclude)
         resourceLoaderOptions.credentialsRequested = ClientRequestedCredentials;
     resourceLoaderOptions.securityOrigin = m_request->origin().get();
 
     ThreadableLoaderOptions threadableLoaderOptions;
     threadableLoaderOptions.contentSecurityPolicyEnforcement = ContentSecurityPolicy::shouldBypassMainWorld(executionContext()) ? DoNotEnforceContentSecurityPolicy : EnforceConnectSrcDirective;
     if (corsPreflightFlag)
         threadableLoaderOptions.preflightPolicy = ForcePreflight;
     switch (m_request->mode()) {
+    case WebURLRequest::FetchRequestModeNavigate:
+        threadableLoaderOptions.crossOriginRequestPolicy = AllowCrossOriginRequests;

[horo, 2015/10/14 10:05:31]

We don't need to allow cross origin requests.
This should be DenyCrossOriginRequests.

[shiva.jm, 2015/10/14 10:59:06]

Done, had same opinion in patchset2, but miss read from git hub discussions.

[hiroshige, 2015/10/15 06:37:03]

horo@,
I want to clarify why this should be DenyCrossOriginRequests here.
The Fetch spec seems to allow cross-origin requests.

[horo, 2015/10/15 11:43:05]

"navigate" request is only available in ServiceWorker.
The request url's origin must be same as the SW's origin.
The request's redirect mode is "manual".
So we don't need to allow cross origin requests.

[yhirano, 2015/10/16 18:15:53]

(to: horo@)
I feel it confusing. How about
 - using AllowCrossOriginRequests,
 - adding an assertion checking that the request url's origin is this origin,
 - adding an assertion about the redirect mode and
 - adding comments?

[horo, 2015/10/19 04:08:13]

Yes, we should have comments.
But I think we should use DenyCrossOriginRequests here to reduce the security
risk.
ASSERT() doesn't work in release build.
So if there are any bugs in handling the request and the response, severe
security accident could happen.

+        break;
     case WebURLRequest::FetchRequestModeSameOrigin:
         threadableLoaderOptions.crossOriginRequestPolicy = DenyCrossOriginRequests;
         break;
     case WebURLRequest::FetchRequestModeNoCORS:
         threadableLoaderOptions.crossOriginRequestPolicy = AllowCrossOriginRequests;
         break;
     case WebURLRequest::FetchRequestModeCORS:
     case WebURLRequest::FetchRequestModeCORSWithForcedPreflight:
         threadableLoaderOptions.crossOriginRequestPolicy = UseAccessControl;
         break;
@@ skipping 69 matching lines @@
     loader->dispose();
 }
 
 DEFINE_TRACE(FetchManager)
 {
     visitor->trace(m_executionContext);
     visitor->trace(m_loaders);
 }
 
 } // namespace blink