test_reflectable/test/reflected_type_test.dart - Issue 1391543003: Creates `reflectors`, as a meta-meta feature that enables dynamic selection of a "mirror system".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test_reflectable/test/reflected_type_test.dart

Issue 1391543003: Creates `reflectors`, as a meta-meta feature that enables dynamic selection of a "mirror system". (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master

Patch Set: Added lots of LibraryMirror support in order to make reflectors work in transformed code Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test_reflectable/test/meta_reflectors_user.dart ('K') | « test_reflectable/test/meta_reflectors_user.dart ('k') | test_reflectable/test/reflectors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test_reflectable/test/reflected_type_test.dart

diff --git a/test_reflectable/test/reflected_type_test.dart b/test_reflectable/test/reflected_type_test.dart

index 7f481f0aa768ecc1d3e0fa6fc12c1ce80dc42c3c..05c88a31e770a453c137c8accd7c4178189cd3a7 100644

--- a/test_reflectable/test/reflected_type_test.dart

+++ b/test_reflectable/test/reflected_type_test.dart

@@ -138,7 +138,7 @@ main() {

expect(namedArgumentsParameter2.reflectedType, String);

});

- test('parameter list properties, getters and setters', () {

+ test('parameter reflected types, static getters and setters', () {

expect(staticGetsetMirror.parameters.length, 0);

expect(staticGetsetEqualsMirror.parameters.length, 1);

ParameterMirror staticGetsetEqualsParameter0 =

@@ -146,7 +146,7 @@ main() {

expect(staticGetsetEqualsParameter0.reflectedType, List);

});

- test("method return types", () {

+ test('reflected return types, methods', () {

expect(arg0Mirror.reflectedReturnType, int);

expect(arg1Mirror.reflectedReturnType, int);

expect(arg2to4Mirror.reflectedReturnType, int);