Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 139153011: Remove unused code (gaia_oauth_fetcher). (Closed)

Created:
6 years, 11 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Remove unused code (gaia_oauth_fetcher). The oauth2 apis are handled by google_apis\gaia\gaia_oauth_client. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245632

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1108 lines) Patch
D chrome/browser/net/gaia/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/net/gaia/gaia_oauth_consumer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/net/gaia/gaia_oauth_fetcher.h View 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 chunk +0 lines, -565 lines 0 comments Download
D chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 chunk +0 lines, -253 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Scott, Tim, Simply removing code that is not called anywhere. Tim: please do owner ...
6 years, 11 months ago (2014-01-17 14:31:12 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-17 16:32:34 UTC) #2
tim (not reviewing)
lgtm
6 years, 11 months ago (2014-01-17 19:12:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/139153011/80001
6 years, 11 months ago (2014-01-17 19:39:39 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 21:55:40 UTC) #5
Message was sent while issue was closed.
Change committed as 245632

Powered by Google App Engine
This is Rietveld 408576698