Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Issue 139153003: drive: Return NOT_FOUND from FakeDriveService after the entry gets deleted (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
tzik
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Return NOT_FOUND from FakeDriveService after the entry gets deleted The real Drive server returns NOT_FOUND for deleted entries. BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245255

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/fake_drive_uploader.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
6 years, 11 months ago (2014-01-16 07:03:33 UTC) #1
tzik
lgtm
6 years, 11 months ago (2014-01-16 07:07:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/139153003/2
6 years, 11 months ago (2014-01-16 07:13:20 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:16:40 UTC) #4
Message was sent while issue was closed.
Change committed as 245255

Powered by Google App Engine
This is Rietveld 408576698