Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1391463002: mac: Add --use-system-default-handler option to crashpad_handler (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Add --use-system-default-handler option to crashpad_handler This is a weird option that causes crashpad_handler to discard the crash handler it inherited and replace it with the system default. Its use is not recommended. BUG=chromium:538373 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/08e5e10167b02de7379d3cd20616bebeeb39c693

Patch Set 1 #

Patch Set 2 : --reset_own_crash_exception_port_to_system_default #

Patch Set 3 : Self-review #

Patch Set 4 : For checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M handler/crashpad_handler.ad View 1 1 chunk +7 lines, -0 lines 0 comments Download
M handler/main.cc View 1 2 3 7 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Mark Mentovai
I don’t like the option name, but I couldn’t come up with anything descriptive, so ...
5 years, 2 months ago (2015-10-05 19:56:12 UTC) #2
Robert Sesek
Should we be adding options whose use is not recommended? Were you only using this ...
5 years, 2 months ago (2015-10-05 21:32:31 UTC) #3
Mark Mentovai
This is for a better fix to bug chromium:538373. Rather than having the relauncher process ...
5 years, 2 months ago (2015-10-05 22:23:18 UTC) #4
Mark Mentovai
I thought about not documenting it in the man page or --help, but I decided ...
5 years, 2 months ago (2015-10-05 22:23:59 UTC) #5
Robert Sesek
lgtm
5 years, 2 months ago (2015-10-05 22:28:07 UTC) #6
Mark Mentovai
No thoughts on better naming?
5 years, 2 months ago (2015-10-05 22:28:46 UTC) #7
Robert Sesek
On 2015/10/05 22:28:46, Mark Mentovai wrote: > No thoughts on better naming? --use-system-exception-handler ?
5 years, 2 months ago (2015-10-05 22:29:47 UTC) #8
Mark Mentovai
Is there anything concise that says “use this for crashpad_handler”? My problem with these names ...
5 years, 2 months ago (2015-10-05 22:31:50 UTC) #9
Mark Mentovai
Updated to use --reset-own-crash-exception-port-to-system-default as discussed. The long name discourages use!
5 years, 2 months ago (2015-10-05 22:53:22 UTC) #10
Mark Mentovai
5 years, 2 months ago (2015-10-06 18:15:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:50001) manually as
08e5e10167b02de7379d3cd20616bebeeb39c693 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698