Extract policy indicator behavior

ui/webui/resources/cr_elements/v1_0/policy/cr_policy_indicator_behavior.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview Behavior for policy controlled indicators.
+ */
+
+/** @enum {string} */
+var CrPolicyIndicatorType = {
+  DEVICE_POLICY: 'devicePolicy',
+  EXTENSION: 'extension',
+  NONE: 'none',
+  OWNER: 'owner',
+  PRIMARY_USER: 'primary_user',
+  RECOMMENDED: 'recommended',
+  USER_POLICY: 'userPolicy',
+};
+
+/** @polymerBehavior */
+var CrPolicyIndicatorBehavior = {
+  /**
+   * @param {CrPolicyIndicatorType} type
+   * @return {boolean} True if the indicator should be shown.
+   * @private
+   */
+  isIndicatorVisible: function(type) {
+    return type != CrPolicyIndicatorType.NONE;
+  },
+
+  /**
+   * @param {CrPolicyIndicatorType} type
+   * @return {string} The iron-icons icon name.
+   * @private
+   */
+  getIcon: function(type) {

[Dan Beam, 2015/10/07 18:40:58]

remember, these are mixed in with |this| on anything that use this behavior. 
this is kind of like an observer interfaces in C++: the methods should probably
be specific enough that we don't conflict/know which interface they belong to
just by looking at the name.

[stevenjb, 2015/10/07 23:37:14]

Fair point. -> getPolicyIndicatorIcon

+    switch (type) {
+      case CrPolicyIndicatorType.NONE:
+        return '';
+      case CrPolicyIndicatorType.PRIMARY_USER:
+        return 'social:group';
+      case CrPolicyIndicatorType.OWNER:
+        return 'social:person';
+      case CrPolicyIndicatorType.USER_POLICY:
+      case CrPolicyIndicatorType.DEVICE_POLICY:
+        return 'social:domain';
+      case CrPolicyIndicatorType.EXTENSION:
+        return 'extension';
+      case CrPolicyIndicatorType.RECOMMENDED:
+        return 'social:domain';
+    }
+    assertNotReached();
+    return '';
+  },
+
+  /**
+   * @param {string} id The id of the string to translate.
+   * @param {string=} opt_name An optional name argument.
+   * @return The translated string.
+   */
+  i18n: function (id, opt_name) {
+    return loadTimeData.getStringF(id, opt_name);
+  },

[Dan Beam, 2015/10/07 18:40:58]

nit: this is probably generic enough to be it's own behavior (and otherwise
would likely conflict when mixed in)

  /**
   * @param {string} id The ID of the translation.
   * @param {...string} var_args Placeholders used in the string.
   * @return {string} The translated text.
   */
  i18n: function(id, var_args) {
    return loadTimeData.getStringF.apply(loadTimeData, arguments);
  },

[stevenjb, 2015/10/07 23:37:14]

Agreed, and it's on my TODO list. In the meanwhile, renamed i18n_.

+
+  /**
+   * @param {CrPolicyIndicatorType} type
+   * @param {string} name The name associated with the controllable. See
+   *     chrome.settingsPrivate.PrefObject.policySourceName
+   * @return {string} The tooltip text for |type|.
+   */
+  getTooltipText: function(type, name) {

[stevenjb, 2015/10/07 23:37:14]

Also renamed -> getPolicyIndicatorTooltip

+    switch (type) {
+      case CrPolicyIndicatorType.PRIMARY_USER:
+        return this.i18n('controlledSettingShared', name);
+      case CrPolicyIndicatorType.OWNER:
+        return this.i18n('controlledSettingOwner', name);
+      case CrPolicyIndicatorType.USER_POLICY:
+      case CrPolicyIndicatorType.DEVICE_POLICY:
+        return this.i18n('controlledSettingPolicy');
+      case CrPolicyIndicatorType.EXTENSION:
+        return this.i18n('controlledSettingExtension', name);
+      case CrPolicyIndicatorType.RECOMMENDED:
+        // This case is not handled here since it requires knowlede of the

[michaelpg, 2015/10/07 18:18:35]

knowledge

[stevenjb, 2015/10/07 18:33:38]

Done.

+        // value and recommended value associated with the controllable.
+        assertNotReached();
+    }
+    return '';
+  }
+};