Issue 139143002: Move RunGN lower so that modifications to os.environ take effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139143002: Move RunGN lower so that modifications to os.environ take effect (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move RunGN lower so that modifications to os.environ take effect Without this the os.environ changes for various default values are not taken into effect by GN. R=brettw@chromium.org BUG=323300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244963

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	build/gyp_chromium	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/139143002/1

6 years, 11 months ago (2014-01-15 05:56:00 UTC) #3

scottmg

6 years, 11 months ago (2014-01-15 19:48:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r244963 (presubmit successful).