Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: test/mjsunit/object-define-property.js

Issue 13914003: Fix detection of indexed properties in Object.defineProperty() (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8natives.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 assertFalse(desc.configurable); 911 assertFalse(desc.configurable);
912 912
913 // Define non existing property - all attributes should default to false. 913 // Define non existing property - all attributes should default to false.
914 Object.defineProperty(arr, '15', descElement); 914 Object.defineProperty(arr, '15', descElement);
915 desc = Object.getOwnPropertyDescriptor(arr, '15'); 915 desc = Object.getOwnPropertyDescriptor(arr, '15');
916 assertEquals(desc.value, 'foobar'); 916 assertEquals(desc.value, 'foobar');
917 assertFalse(desc.writable); 917 assertFalse(desc.writable);
918 assertFalse(desc.enumerable); 918 assertFalse(desc.enumerable);
919 assertFalse(desc.configurable); 919 assertFalse(desc.configurable);
920 920
921 // Define non-array property, check that .length is unaffected.
922 assertEquals(16, arr.length);
923 Object.defineProperty(arr, '0x20', descElement);
924 assertEquals(16, arr.length);
925
921 // See issue 968: http://code.google.com/p/v8/issues/detail?id=968 926 // See issue 968: http://code.google.com/p/v8/issues/detail?id=968
922 var o = { x : 42 }; 927 var o = { x : 42 };
923 Object.defineProperty(o, "x", { writable: false }); 928 Object.defineProperty(o, "x", { writable: false });
924 assertEquals(42, o.x); 929 assertEquals(42, o.x);
925 o.x = 37; 930 o.x = 37;
926 assertEquals(42, o.x); 931 assertEquals(42, o.x);
927 932
928 o = { x : 42 }; 933 o = { x : 42 };
929 Object.defineProperty(o, "x", {}); 934 Object.defineProperty(o, "x", {});
930 assertEquals(42, o.x); 935 assertEquals(42, o.x);
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 o.blubb = 123; 1188 o.blubb = 123;
1184 } 1189 }
1185 1190
1186 function C() {} 1191 function C() {}
1187 1192
1188 Assign(new C); 1193 Assign(new C);
1189 Assign(new C); 1194 Assign(new C);
1190 %OptimizeFunctionOnNextCall(Assign); 1195 %OptimizeFunctionOnNextCall(Assign);
1191 Object.defineProperty(C.prototype, "blubb", {get: function() { return -42; }}); 1196 Object.defineProperty(C.prototype, "blubb", {get: function() { return -42; }});
1192 Assign(new C); 1197 Assign(new C);
OLDNEW
« no previous file with comments | « src/v8natives.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698