third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-updown-events.html - Issue 1391393002: Fire pointerup/down events for corresponding mouse events.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-updown-events.html

Issue 1391393002: Fire pointerup/down events for corresponding mouse events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html ('K') | « third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-preventdefault-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-updown-events-expected.txt » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../../resources/js-test.js"></script>

	3 <style>

	4 div {

	5 margin: 10px;

	6 padding: 50px;

	7 float: left;

	8 }

	9 #console {

	10 padding: 0px;

	11 float: none;
	Rick Byers 2015/10/20 19:09:50 curious why you need these rules. If the console curious why you need these rules. If the console is getting in your way you can use the lazy test output option to avoid actually updating the DOM until the test is complete. mustaq 2015/10/21 15:17:21 I try to make the console divs sane to ease quick Show quoted text On 2015/10/20 19:09:50, Rick Byers wrote: > curious why you need these rules. If the console is getting in your way you can > use the lazy test output option to avoid actually updating the DOM until the > test is complete. I try to make the console divs sane to ease quick manual testing (through file:// or jsbin etc.). Not a strong point though. I will remove it if you still prefer minimal styling here. Rick Byers 2015/10/22 21:31:51 Yeah that makes sense, just wondering who the heck Show quoted text On 2015/10/21 15:17:21, mustaq wrote: > On 2015/10/20 19:09:50, Rick Byers wrote: > > curious why you need these rules. If the console is getting in your way you > can > > use the lazy test output option to avoid actually updating the DOM until the > > test is complete. > > I try to make the console divs sane to ease quick manual testing (through > file:// or jsbin etc.). Not a strong point though. I will remove it if you still > prefer minimal styling here. Yeah that makes sense, just wondering who the heck is putting a float or non-zero padding on the console. js-test.js doesn't do that by default (it's just a simple div in the pages I've seen with a couple minor css rules). mustaq 2015/10/23 14:59:44 The generic 'div' style I set above is the culprit Show quoted text On 2015/10/22 21:31:51, Rick Byers wrote: > On 2015/10/21 15:17:21, mustaq wrote: > > On 2015/10/20 19:09:50, Rick Byers wrote: > > > curious why you need these rules. If the console is getting in your way you > > can > > > use the lazy test output option to avoid actually updating the DOM until the > > > test is complete. > > > > I try to make the console divs sane to ease quick manual testing (through > > file:// or jsbin etc.). Not a strong point though. I will remove it if you > still > > prefer minimal styling here. > > Yeah that makes sense, just wondering who the heck is putting a float or > non-zero padding on the console. js-test.js doesn't do that by default (it's > just a simple div in the pages I've seen with a couple minor css rules). The generic 'div' style I set above is the culprit. Didn't even notice it's a copy of a hack I hadn't meant to submit originally. Fixed all copies, yikes!
	12 }

	13 </style>

	14

	15 <div id="green" style="background-color:green">

	16 </div>

	17

	18 <div id="blue" style="background-color:blue">

	19 </div>

	20

	21 <div id="console"></div>

	22

	23 <script>

	24 description("Verifies that pointerup/down are fired correctly for correponding m ouse events.");

	25

	26 var eventToPreventDefault = "";
	Rick Byers 2015/10/20 19:09:50 Isn't this really redundant with your preventDefau Isn't this really redundant with your preventDefault test? mustaq 2015/10/21 15:17:21 Done, left only the tests for bubbled events here. Show quoted text On 2015/10/20 19:09:50, Rick Byers wrote: > Isn't this really redundant with your preventDefault test? Done, left only the tests for bubbled events here.
	27

	28 function init() {

	29 var eventList = ["mousedown", "mouseup", "pointerdown", "pointerup"];

	30

	31 ["green", "blue"].forEach(function(id) {

	32 var targetDiv = document.getElementById(id);

	33

	34 eventList.forEach(function(eventName) {

	35 targetDiv.addEventListener(eventName, function(event) {

	36 if (event.eventPhase != Event.AT_TARGET)

	37 return;

	38

	39 var preventDefaultMsg = "";

	40 if (event.type == eventToPreventDefault && id == "blue") {

	41 event.preventDefault();

	42 preventDefaultMsg = ", prevented default";

	43 }

	44

	45 debug(id + " received " + event.type + preventDefaultMsg);

	46 });

	47 });

	48 });

	49 }

	50

	51 function runTests() {

	52 var rect = document.getElementById("green").getBoundingClientRect();

	53 var x1 = rect.left + 5;

	54 var y1 = rect.top + 5;

	55

	56 var rect = document.getElementById("blue").getBoundingClientRect();

	57 var x2 = rect.left + 5;

	58 var y2 = rect.top + 5;

	59

	60 var preventDefaultEventList = ["none", "pointerup", "pointerdown"];

	61

	62 preventDefaultEventList.forEach(function(preventDefaultEvent) {

	63 debug("--- test with preventDefault on " + preventDefaultEvent + "---");

	64 eventToPreventDefault = preventDefaultEvent;

	65

	66 eventSender.mouseMoveTo(x1, y1);

	67 eventSender.mouseDown();

	68

	69 eventSender.mouseMoveTo(x2, y2);

	70 eventSender.mouseUp();

	71 eventSender.mouseDown();

	72

	73 eventSender.mouseMoveTo(x1, y1);

	74 eventSender.mouseUp();

	75 eventSender.mouseDown();

	76 eventSender.mouseUp();

	77

	78 debug("");

	79 });

	80 }

	81

	82 init();

	83 if (window.eventSender)

	84 runTests();

	85 else

	86 debug("This test requires eventSender");

	87

	88 </script>

OLD	NEW