Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391363002: Extend components/test_runner's generated WebMediaStream to have a Chrome VideoTrack and Source (Closed)

Created:
5 years, 2 months ago by mcasas
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, imcheng+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, darin-cc_chromium.org, blink-reviews, xjz+watch_chromium.org, isheriff+watch_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend components/test_runner's generated WebMediaStream to have a Chrome VideoTrack and Source BUG=262211, 532509 Committed: https://crrev.com/43ff56ff2bc004d542aa020b21655079e36ac441 Cr-Commit-Position: refs/heads/master@{#353012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -74 lines) Patch
M components/html_viewer/web_test_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/web_test_delegate_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M components/test_runner/test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_api.h View 2 chunks +14 lines, -6 lines 0 comments Download
M content/public/renderer/media_stream_api.cc View 3 chunks +45 lines, -44 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-basic-video-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mcasas
sky@: PTAL at components/html_viewer/web_test_delegate_impl.* dpranke@: PTAL at components/test_runner/* (dmazzoni@ LGTMd a similar set of changes ...
5 years, 2 months ago (2015-10-07 21:24:06 UTC) #3
sky
LGTM
5 years, 2 months ago (2015-10-07 23:39:30 UTC) #4
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-08 00:52:54 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-10-08 03:04:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391363002/20001
5 years, 2 months ago (2015-10-08 05:20:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-08 05:24:50 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 05:25:31 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/43ff56ff2bc004d542aa020b21655079e36ac441
Cr-Commit-Position: refs/heads/master@{#353012}

Powered by Google App Engine
This is Rietveld 408576698