Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1391353002: Dartium typed js interop work dart repo side of the change. Also tries to get (Closed)

Created:
5 years, 2 months ago by Jacob
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dartium typed js interop work dart repo side of the change. Also tries to get BUG= Committed: https://github.com/dart-lang/sdk/commit/8d793ca7588b49ab22aee59ab98ab98ceb1ab558

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -111 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 17 chunks +97 lines, -41 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 12 chunks +300 lines, -30 lines 0 comments Download
M tests/html/js_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 9 chunks +76 lines, -15 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +6 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 3 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jacob
5 years, 2 months ago (2015-10-07 18:44:57 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8d793ca7588b49ab22aee59ab98ab98ceb1ab558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698