Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391333004: remove internalDrawBitmap (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove internalDrawBitmap, as it is no longer shared with any other caller, and can be folded into onDrawBitmap BUG=skia: Committed: https://skia.googlesource.com/skia/+/33366974d43eae80e22284a2e445225c343859da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -45 lines) Patch
M include/core/SkCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +25 lines, -42 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391333004/1
5 years, 2 months ago (2015-10-08 15:47:19 UTC) #2
reed1
ptal -- pre-cl to trying to optimize imagefilters w/ drawbitmap (to be like drawsprite in ...
5 years, 2 months ago (2015-10-08 15:48:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 15:53:53 UTC) #6
robertphillips
lgtm
5 years, 2 months ago (2015-10-08 16:08:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391333004/1
5 years, 2 months ago (2015-10-08 16:21:09 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 16:22:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/33366974d43eae80e22284a2e445225c343859da

Powered by Google App Engine
This is Rietveld 408576698