Issue 139133004: Merged r19024, r19026 into trunk branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139133004: Merged r19024, r19026 into trunk branch. (Closed)

Created:
6 years, 10 months ago by Hannes Payer (out of office)

Modified:
6 years, 10 months ago

Reviewers:
Michael Achenbach, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Merged r19024, r19026 into trunk branch. Make memento checks more stable. Add filler at the end of new space and check if object and memento are on the same new space page. Elements field of newly allocated JSArray could be left uninitialized in some cases (fast literal case). BUG=340124 LOG=N R=jkummerow@chromium.org, machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19029

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -28 lines)			Patch
M	src/heap.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+15 lines, -9 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+15 lines, -4 lines	0 comments	Download
M	src/spaces.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

6 years, 10 months ago (2014-02-03 14:21:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19029.

Expand Messages | Collapse Messages