Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1391323003: Enable WebVR for LayoutTests (Closed)

Created:
5 years, 2 months ago by lgombos
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebVR during layout testing. The primary motivation at this time is to make sure that WebVR does not introduce any regression in other parts of the software. BUG=389343 Committed: https://crrev.com/36bd4b148293adc0b4ba169b7dfb789d65f3f516 Cr-Commit-Position: refs/heads/master@{#353530}

Patch Set 1 #

Patch Set 2 : Fix syntax #

Patch Set 3 : Fix LayoutTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 4 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
lgombos
Brandon, what do you think ? This would help catching issues like this much earlier ...
5 years, 2 months ago (2015-10-11 17:53:39 UTC) #2
bajones
I think this is a great precautionary measure. Thank you! LGTM.
5 years, 2 months ago (2015-10-11 22:05:45 UTC) #3
lgombos
jochen@chromium.org: Please review changes in RuntimeEnabledFeatures.in This will only impact what we test and not ...
5 years, 2 months ago (2015-10-12 02:20:44 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-12 11:03:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391323003/40001
5 years, 2 months ago (2015-10-12 13:38:48 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
5 years, 2 months ago (2015-10-12 15:29:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391323003/40001
5 years, 2 months ago (2015-10-12 16:15:08 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-12 16:22:46 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 16:24:18 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/36bd4b148293adc0b4ba169b7dfb789d65f3f516
Cr-Commit-Position: refs/heads/master@{#353530}

Powered by Google App Engine
This is Rietveld 408576698