Polished update screen.

chrome/browser/resources/chromeos/login/oobe_screen_update.js

Index: chrome/browser/resources/chromeos/login/oobe_screen_update.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_update.js b/chrome/browser/resources/chromeos/login/oobe_screen_update.js
index 070ee32607f5b2665aa5ce1c0baebf1f20ee249a..26d3366ac9e793f512361841742ad9cfb2507cb2 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_update.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_update.js
@@ -14,9 +14,6 @@ cr.define('oobe', function() {
    */
   var UpdateScreen = cr.ui.define('div');
 
-  /** @const */ var ELLIPSIS = ['', '.', '..', '...'];
-  /** @const */ var ELLIPSIS_ANIMATION_TIMEOUT_MS = 1000;
-
   /**
    * Registers with Oobe.
    */
@@ -33,14 +30,6 @@ cr.define('oobe', function() {
     decorate: function() {
     },
 
-    onBeforeShow: function(data) {
-      UpdateScreen.startEllipsisAnimation();

[Nikita (slow), 2013/04/10 04:52:05]

I think you should specifically add rule like "display: none"  when screen is
hidden and remove that when screen is shown to prevent animation happening when
visibility is hidden.

[Nikita (slow), 2013/04/12 12:54:39]

What about this comment?

-    },
-
-    onBeforeHide: function() {
-      UpdateScreen.stopEllipsisAnimation();
-    },
-
     /**
      * Header text of the screen.
      * @type {string}
@@ -50,14 +39,6 @@ cr.define('oobe', function() {
     },
 
     /**
-     * Buttons in oobe wizard's button strip.
-     * @type {array} Array of Buttons.
-     */
-    get buttons() {
-      return null;
-    },
-
-    /**
      * Cancels the screen.
      */
     cancel: function() {
@@ -70,23 +51,6 @@ cr.define('oobe', function() {
     },
   };
 
-  var ellipsisAnimationActive = false;
-
-  /**
-   * Updates number of dots in the ellipsis.
-   *
-   * @private
-   * @param {number} count Number of dots that should be shown.
-   */
-  function updateEllipsisAnimation_(count) {
-    $('update-checking-ellipsis').textContent = ELLIPSIS[count];
-    if (ellipsisAnimationActive) {
-      window.setTimeout(function() {
-          updateEllipsisAnimation_((count + 1) % ELLIPSIS.length);
-        }, ELLIPSIS_ANIMATION_TIMEOUT_MS);
-    }
-  };
-
   /**
    * Makes 'press Escape to cancel update' hint visible.
    */
@@ -94,21 +58,6 @@ cr.define('oobe', function() {
     $('update-cancel-hint').hidden = false;
   };
 
-  /**
-   * Starts animation for tail ellipses in "Checking for update..." label.
-   */
-  UpdateScreen.startEllipsisAnimation = function() {
-    ellipsisAnimationActive = true;
-    updateEllipsisAnimation_(0);
-  };
-
-  /**
-   * Stops animation for tail ellipses in "Checking for update..." label.
-   */
-  UpdateScreen.stopEllipsisAnimation = function() {
-    ellipsisAnimationActive = false;
-  };
-
   return {
     UpdateScreen: UpdateScreen
   };