Chromium Code Reviews| Index: chrome/browser/resources/file_manager/js/directory_contents.js |
| diff --git a/chrome/browser/resources/file_manager/js/directory_contents.js b/chrome/browser/resources/file_manager/js/directory_contents.js |
| index e7613a00b9af686bf413d7cc4a0ecc106c201fe0..d2af3702f6ff4e8ad4e05f772d8f00337907d9df 100644 |
| --- a/chrome/browser/resources/file_manager/js/directory_contents.js |
| +++ b/chrome/browser/resources/file_manager/js/directory_contents.js |
| @@ -827,7 +827,7 @@ DirectoryContentsDriveSearchMetadata.prototype.readNextChunk = function() { |
| this.lastChunkReceived(); |
| }).bind(this); |
| - var types = 'ALL'; |
| + var types; |
|
not at google - send to devlin
2013/04/09 23:07:07
nit: initialize to null if it's intended as legiti
Haruki Sato
2013/04/10 03:56:30
Thanks. In this case, we would like to initialize
|
| switch (this.searchType_) { |
| case DirectoryContentsDriveSearchMetadata.SearchType.SEARCH_ALL: |
| types = 'ALL'; |
| @@ -835,14 +835,12 @@ DirectoryContentsDriveSearchMetadata.prototype.readNextChunk = function() { |
| case DirectoryContentsDriveSearchMetadata.SearchType.SEARCH_SHARED_WITH_ME: |
| types = 'SHARED_WITH_ME'; |
|
not at google - send to devlin
2013/04/09 23:07:07
nit: break after. Good practice.
Haruki Sato
2013/04/10 03:56:30
Done. Thanks.
|
| } |
| - // TODO(haruki): Pass the search type when searchDriveMetadata support is |
| - // implemented. |
| - // var searchParams = { |
| - // 'query': this.query_, |
| - // 'types': types, |
| - // 'maxResults': 500, |
| - // }; |
| - chrome.fileBrowserPrivate.searchDriveMetadata(this.query_, searchCallback); |
| + var searchParams = { |
| + 'query': this.query_, |
| + 'types': types, |
| + 'maxResults': 500, |
|
yoshiki
2013/04/10 02:57:29
nit: remove the last comma for consistency.
Haruki Sato
2013/04/10 03:56:30
Done.
|
| + }; |
| + chrome.fileBrowserPrivate.searchDriveMetadata(searchParams, searchCallback); |
| }; |
| /** |