filemanger: Pass SHARED_WITH_ME search type to searchDriveMetadata().

filemanger: Pass SHARED_WITH_ME search type to searchDriveMetadata().

This CL updates the private-API spec and pass the corresponding enum to the API.
C++ side implementation is done in another CL.

BUG=168722
TEST=unittests. Open Files App and verify the functions.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193344

[Haruki Sato, 2013-04-09 14:24:16]

Benjamin, could you take a look at file_browser_private.json change.

Yoshiki, could you take a look at filemanager JS change?

[not at google - send to devlin, 2013-04-09 23:07:07]

lgtm

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:830: var types;
nit: initialize to null if it's intended as legitimate input.

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:836: types =
'SHARED_WITH_ME';
nit: break after. Good practice.

[yoshiki, 2013-04-10 02:57:29]

lgtm with nit

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:841:
'maxResults': 500,
nit: remove the last comma for consistency.

[Haruki Sato, 2013-04-10 03:56:30]

Thank you for the review. Please let me know if you have any other concern.

Thanks!

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:830: var types;
On 2013/04/09 23:07:07, kalman wrote:
> nit: initialize to null if it's intended as legitimate input.

Thanks. In this case, we would like to initialize it in the following
switch-case.

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:836: types =
'SHARED_WITH_ME';
On 2013/04/09 23:07:07, kalman wrote:
> nit: break after. Good practice.

Done. Thanks.

https://codereview.chromium.org/13913009/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:841:
'maxResults': 500,
On 2013/04/10 02:57:29, yoshiki wrote:
> nit: remove the last comma for consistency.

Done.

[commit-bot: I haz the power, 2013-04-10 03:56:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/13913009/8001

[not at google - send to devlin, 2013-04-10 03:58:02]

https://codereview.chromium.org/13913009/diff/8001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/13913009/diff/8001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_contents.js:837: break;
then add a "default: throw Error()" case?

[Haruki Sato, 2013-04-10 04:01:18]

https://codereview.chromium.org/13913009/diff/8001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/13913009/diff/8001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_contents.js:837: break;
On 2013/04/10 03:58:02, kalman wrote:
> then add a "default: throw Error()" case?

Done. Thanks!

[commit-bot: I haz the power, 2013-04-10 04:01:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/13913009/13003

[commit-bot: I haz the power, 2013-04-10 08:09:26]

Change committed as 193344