Issue 1391273002: Fixed few more issues with upgrader and custom event identitiy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1391273002: Fixed few more issues with upgrader and custom event identitiy (Closed)

Created:
5 years, 2 months ago by terry

Modified:
5 years, 2 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed few more issues with upgrader and custom event identitiy TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/ff5d07a4e9decc2b3f601961d28ef771f66140f5

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -4 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+33 lines, -2 lines	0 comments	Download
M	tools/dom/src/dartium_CustomElementSupport.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	2 chunks	+26 lines, -2 lines	1 comment	Download
M	tools/dom/templates/html/impl/impl_CustomEvent.darttemplate	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

terry

Committed patchset #1 (id:1) manually as ff5d07a4e9decc2b3f601961d28ef771f66140f5 (presubmit successful).

5 years, 2 months ago (2015-10-07 15:53:39 UTC) #1

Alan Knight

5 years, 2 months ago (2015-10-07 16:21:29 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1391273002/diff/1/tools/dom/templates/html/da...
File tools/dom/templates/html/dartium/html_dartium.darttemplate (right):

https://codereview.chromium.org/1391273002/diff/1/tools/dom/templates/html/da...
tools/dom/templates/html/dartium/html_dartium.darttemplate:502: if
(dartInstanceMirror.type.qualifiedName == #dart.dom.html.HtmlElement) {
Could you do this with dartInstance.runtimeType == HtmlElement rather than using
mirrors?

Expand Messages | Collapse Messages