Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: Source/core/page/PerformanceResourceTiming.cpp

Issue 13912021: [Resource Timing] Expose redirect timing information (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2nd Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PerformanceResourceTiming.cpp
diff --git a/Source/core/page/PerformanceResourceTiming.cpp b/Source/core/page/PerformanceResourceTiming.cpp
index c2f3c2897d37334584257994ea75f62ba3477b61..5046a08c124359ba2f538c3c318407611d8008a8 100644
--- a/Source/core/page/PerformanceResourceTiming.cpp
+++ b/Source/core/page/PerformanceResourceTiming.cpp
@@ -38,6 +38,7 @@
#include "KURL.h"
#include "ResourceRequest.h"
#include "ResourceResponse.h"
+#include "ResourceTimingInfo.h"
#include "SecurityOrigin.h"
#include <wtf/Vector.h>
@@ -49,40 +50,17 @@ static double monotonicTimeToDocumentMilliseconds(Document* document, double sec
return document->loader()->timing()->monotonicTimeToZeroBasedDocumentTime(seconds) * 1000.0;
}
-static bool passesTimingAllowCheck(const ResourceResponse& response, Document* requestingDocument)
-{
- AtomicallyInitializedStatic(AtomicString&, timingAllowOrigin = *new AtomicString("timing-allow-origin"));
-
- RefPtr<SecurityOrigin> resourceOrigin = SecurityOrigin::create(response.url());
- if (resourceOrigin->isSameSchemeHostPort(requestingDocument->securityOrigin()))
- return true;
-
- const String& timingAllowOriginString = response.httpHeaderField(timingAllowOrigin);
- if (timingAllowOriginString.isEmpty() || equalIgnoringCase(timingAllowOriginString, "null"))
- return false;
-
- if (timingAllowOriginString == "*")
- return true;
-
- const String& securityOrigin = requestingDocument->securityOrigin()->toString();
- Vector<String> timingAllowOrigins;
- timingAllowOriginString.split(" ", timingAllowOrigins);
- for (size_t i = 0; i < timingAllowOrigins.size(); ++i)
- if (timingAllowOrigins[i] == securityOrigin)
- return true;
-
- return false;
-}
-
-PerformanceResourceTiming::PerformanceResourceTiming(const AtomicString& initiatorType, const ResourceRequest& request, const ResourceResponse& response, double initiationTime, double finishTime, Document* requestingDocument)
- : PerformanceEntry(request.url().string(), "resource", monotonicTimeToDocumentMilliseconds(requestingDocument, initiationTime), monotonicTimeToDocumentMilliseconds(requestingDocument, finishTime))
- , m_initiatorType(initiatorType)
- , m_timing(response.resourceLoadTiming())
- , m_finishTime(finishTime)
- , m_didReuseConnection(response.connectionReused())
- , m_shouldReportDetails(passesTimingAllowCheck(response, requestingDocument))
+PerformanceResourceTiming::PerformanceResourceTiming(const ResourceTimingInfo& info, Document* requestingDocument, double startTime, double lastRedirectEndTime, bool shouldReportDetails)
+ : PerformanceEntry(info.initialRequest().url().string(), "resource", monotonicTimeToDocumentMilliseconds(requestingDocument, startTime), monotonicTimeToDocumentMilliseconds(requestingDocument, info.loadFinishTime()))
+ , m_initiatorType(info.initiatorType())
+ , m_timing(info.finalResponse().resourceLoadTiming())
+ , m_lastRedirectEndTime(lastRedirectEndTime)
+ , m_finishTime(info.loadFinishTime())
+ , m_didReuseConnection(info.finalResponse().connectionReused())
+ , m_shouldReportDetails(shouldReportDetails)
, m_requestingDocument(requestingDocument)
{
+ ASSERT(m_timing);
}
PerformanceResourceTiming::~PerformanceResourceTiming()
@@ -96,23 +74,26 @@ AtomicString PerformanceResourceTiming::initiatorType() const
double PerformanceResourceTiming::redirectStart() const
{
- // FIXME: Need to track and report redirects for resources.
- if (!m_shouldReportDetails)
+ if (!m_shouldReportDetails || !m_lastRedirectEndTime)
return 0.0;
- return 0;
+
+ return PerformanceEntry::startTime();
}
double PerformanceResourceTiming::redirectEnd() const
{
- if (!m_shouldReportDetails)
+ if (!m_shouldReportDetails || !m_lastRedirectEndTime)
return 0.0;
- return 0;
+
+ return monotonicTimeToDocumentMilliseconds(m_requestingDocument.get(), m_lastRedirectEndTime);
}
double PerformanceResourceTiming::fetchStart() const
{
- // FIXME: This should be different depending on redirects.
- return (startTime());
+ if (m_lastRedirectEndTime)
+ return monotonicTimeToDocumentMilliseconds(m_requestingDocument.get(), m_timing->requestTime);
+
+ return PerformanceEntry::startTime();
}
double PerformanceResourceTiming::domainLookupStart() const
@@ -182,7 +163,7 @@ double PerformanceResourceTiming::requestStart() const
if (!m_shouldReportDetails)
return 0.0;
- if (!m_timing)
+ if (!m_timing || m_timing->sendStart < 0)
return connectEnd();
return resourceTimeToDocumentMilliseconds(m_timing->sendStart);
@@ -193,7 +174,7 @@ double PerformanceResourceTiming::responseStart() const
if (!m_shouldReportDetails)
return 0.0;
- if (!m_timing)
+ if (!m_timing || m_timing->receiveHeadersEnd < 0)
return requestStart();
// FIXME: This number isn't exactly correct. See the notes in PerformanceTiming::responseStart().
return resourceTimeToDocumentMilliseconds(m_timing->receiveHeadersEnd);

Powered by Google App Engine
This is Rietveld 408576698