Issue 13912020: Revert "Remove empty layer hack in RenderLayerCompositor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13912020: Revert "Remove empty layer hack in RenderLayerCompositor" (Closed)

Created:
7 years, 8 months ago by Sami

Modified:
7 years, 8 months ago

Reviewers:
enne (OOO)

CC:
blink-reviews, jchaffraix+rendering, jamesr, Tom Hudson

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Revert "Remove empty layer hack in RenderLayerCompositor" This reverts commit 147831: > There is absolutely no reason to consider empty layers as > having a (1, 1) size in the RLC overlap map. This only > creates unnecessary layer promotion. > > This is a relanding in blink of > https://bugs.webkit.org/show_bug.cgi?id=63499 > > Review URL: https://codereview.chromium.org/13431004 This patch caused a 25% regression on JSGameBench scores on platforms that use impl-side painting. BUG=230147 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148562

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	Source/WebCore/rendering/RenderLayerCompositor.cpp	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

enne (OOO)

lgtm. Better to revert for now and investigate what we can do about performance later. ...

7 years, 8 months ago (2013-04-17 16:13:50 UTC) #2

Sami

7 years, 8 months ago (2013-04-17 17:07:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r148562 (presubmit successful).