Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3431)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 13912016: [Autofill] Handle the Tab Key in the new UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Switch to ObserverList and AddTest Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/browser/renderer_host/render_widget_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index 0be00d1f8ea3db91c0f0e13f453330f90ff39eab..9814ec4a780f688782b88abaac50f6da4019ef5e 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -210,6 +210,12 @@ bool AutofillPopupControllerImpl::HandleKeyPressEvent(
case ui::VKEY_DELETE:
return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&
RemoveSelectedLine();
+ case ui::VKEY_TAB:
+ // A tab press should cause the highlighted line to be selected, but still
+ // return false so the tab key press propagates and changes the cursor
+ // location.
+ AcceptSelectedLine();
+ return false;
case ui::VKEY_RETURN:
return AcceptSelectedLine();
default:
« no previous file with comments | « chrome/browser/autofill/autofill_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/browser/renderer_host/render_widget_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698