Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4807)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 13912016: [Autofill] Handle the Tab Key in the new UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index e310f8a1eb546f238146986b5f0bb387e4fe10c0..56aab618651941e61bd5b38b67cae1d0ede84912 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -213,6 +213,12 @@ bool AutofillPopupControllerImpl::HandleKeyPressEvent(
case ui::VKEY_DELETE:
return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&
RemoveSelectedLine();
+ case ui::VKEY_TAB:
+ // A tab press should cause the highlighted line to be selected, but still
+ // return false so the tab key press propagates and changes the cursor
+ // location.
+ AcceptSelectedLine();
+ return false;
case ui::VKEY_RETURN:
return AcceptSelectedLine();
default:

Powered by Google App Engine
This is Rietveld 408576698