Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391193002: Make computeSignature private to modelx. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sra1, sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -56 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 13 chunks +51 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 4 chunks +6 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
Main changes in modelx.dart
5 years, 2 months ago (2015-10-07 11:26:59 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1391193002/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1391193002/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode1996 pkg/compiler/lib/src/elements/modelx.dart:1996: void set functionSignature(FunctionSignature value) { The setter could ...
5 years, 2 months ago (2015-10-07 11:53:07 UTC) #3
Johnni Winther
https://codereview.chromium.org/1391193002/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1391193002/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode1996 pkg/compiler/lib/src/elements/modelx.dart:1996: void set functionSignature(FunctionSignature value) { On 2015/10/07 11:53:07, sigurdm ...
5 years, 2 months ago (2015-10-07 12:15:03 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as b3b7dc94ac0ae5c3ff1a6d3c9efde2f4c200b4d4 (presubmit successful).
5 years, 2 months ago (2015-10-07 12:15:37 UTC) #5
sra1
5 years, 2 months ago (2015-10-07 19:32:41 UTC) #7
Message was sent while issue was closed. 
This and/or the previous CL made the cps_ir bot red.

@@@BUILD_STEP dart2js-d8 tests --dart2js-batch --cps-ir failures@@@

FAILED: dart2js-d8 release_ia32 language/generic_field_mixin4_test
Expected: Pass 
Actual: Crash
Unexpected compile-time error.
CommandOutput[dart2js]:

stdout:
out/ReleaseIA32/dart-sdk/lib/_internal/js_runtime/lib/js_rti.dart:126:1:
Internal Error: The compiler crashed when compiling this element.
getRuntimeTypeArgument(Object target, String substitutionName, int index) {
^^^^^^^^^^^^^^^^^^^^^^
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

* the name and version of your operating system,

* the Dart SDK build number
(1.13.0-edge.b3b7dc94ac0ae5c3ff1a6d3c9efde2f4c200b4d4), and

* the entire message you see here (including the full stack trace
  below as well as the source location above).

The compiler crashed: Class 'PartialMethodElement' has no instance getter
'initializer'.

NoSuchMethodError: method not found: 'initializer'
Receiver: Instance of 'PartialMethodElement'
Arguments: []
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#2      ClosureTask.computeClosureToClassMapping.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/closure.dart:63)
#3      CompilerTask.measure
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/common/tasks.dart:55)
#4      ClosureTask.computeClosureToClassMapping
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/closure.dart:47)
#5      JsIrBuilderVisitor.buildFunction
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3182)
#6      JsIrBuilderVisitor.buildExecutable.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2638)
#7      IrBuilderVisitor.nullIfGiveup
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2255)
#8      JsIrBuilderVisitor.buildExecutable
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2624)
#9      IrBuilderTask.buildNode.<anonymous closure>.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:95)
#10     _CompilerDiagnosticReporter.withCurrentElement
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1692)
#11     IrBuilderTask.buildNode.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:88)
#12     CompilerTask.measure
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/common/tasks.dart:55)
#13     IrBuilderTask.buildNode
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:83)
#14     CpsFunctionCompiler.compileToCpsIr
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/js_backend/codegen/task.dart:132)
#15     CpsFunctionCompiler.compile.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/js_backend/codegen/task.dart:99)
#16     _CompilerDiagnosticReporter.withCurrentElement
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1692)
#17     CpsFunctionCompiler.compile
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/js_backend/codegen/task.dart:86)
#18     JavaScriptBackend.codegen
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/js_backend/backend.dart:1541)
#19     Compiler.codegen
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1224)
#20     CodegenWorkItem.run
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/common/codegen.dart:212)
#21     Compiler.emptyQueue.<anonymous closure>.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1103)
#22     _CompilerDiagnosticReporter.withCurrentElement
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1692)
#23     Compiler.emptyQueue.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1102)
#24     QueueFilter.processWorkItem
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/enqueue.dart:1059)
#25     Enqueuer.forEach
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/enqueue.dart:751)
#26     Compiler.emptyQueue
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1101)
#27     Compiler.processQueue
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1129)
#28     Compiler.compileLoadedLibraries
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:1052)
#29     Compiler.runCompiler.<anonymous closure>
(file:///mnt/data/b/build/slave/dart2js-linux-release-cps-be/build/sdk/pkg/compiler/lib/src/compiler.dart:880)
#30     _RootZone.runUnary (dart:async/zone.dart:1149)
#31     _Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:502)
#32     _Future._propagateToListeners (dart:async/future_impl.dart:585)
#33     _Future._completeWithValue (dart:async/future_impl.dart:376)
#34     _Future._asyncComplete.<anonymous closure>
(dart:async/future_impl.dart:430)
#35     _microtaskLoop (dart:async/schedule_microtask.dart:43)
#36     _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#37     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#38     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:151)

Powered by Google App Engine
This is Rietveld 408576698