third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp - Issue 1391153004: Make StringImpl's content immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

Issue 1391153004: Make StringImpl's content immutable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

index 5a4771201475d190c3aee72441442f944edba109..9eb724477a63174f60d17f5f8e6e111743d14b3d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

@@ -360,8 +360,8 @@ String SerializedScriptValueWriter::takeWireString()

{

static_assert(sizeof(BufferValueType) == 2, "BufferValueType should be 2 bytes");

fillHole();

- String data = String(m_buffer.data(), m_buffer.size());

- data.impl()->truncateAssumingIsolated((m_position + 1) / sizeof(BufferValueType));

+ ASSERT((m_position + 1) / sizeof(BufferValueType) <= m_buffer.size());

+ String data = String(m_buffer.data(), (m_position + 1) / sizeof(BufferValueType));

haraken 2015/10/13 07:40:29 return String(...)

hajimehoshi 2015/10/13 07:51:17 Done.

return data;

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringBuffer.h » ('j') | third_party/WebKit/Source/wtf/text/StringBuffer.h » ('J')