Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1391143006: Fixed native element extension, custom events, _VMUpgrader, and data binding. (Closed)

Created:
5 years, 2 months ago by terry
Modified:
5 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed native element extension, custom events, _VMUpgrader, and data binding. Enabled tests that exercise this areas. TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/4653701a7656136d2725b76497cf1a67a15dd4f4

Patch Set 1 #

Patch Set 2 : Merged conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -120 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 13 chunks +164 lines, -59 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 2 chunks +25 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 5 chunks +82 lines, -53 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CustomEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 5 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
terry
Committed patchset #2 (id:20001) manually as 4653701a7656136d2725b76497cf1a67a15dd4f4 (presubmit successful).
5 years, 2 months ago (2015-10-14 17:04:04 UTC) #1
Alan Knight
5 years, 2 months ago (2015-10-14 20:49:22 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698