Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2605)

Unified Diff: net/http/proxy_client_socket.cc

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/proxy_client_socket.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/proxy_client_socket.cc
diff --git a/net/http/proxy_client_socket.cc b/net/http/proxy_client_socket.cc
index 3094b436a20b5fd5ea4aeeb9ce45888393bb3875..12a517a27a9b81ac7b6eec8294245d62f5936573 100644
--- a/net/http/proxy_client_socket.cc
+++ b/net/http/proxy_client_socket.cc
@@ -57,18 +57,6 @@ void ProxyClientSocket::BuildTunnelRequest(
}
// static
-int ProxyClientSocket::HandleProxyAuthChallenge(HttpAuthController* auth,
- HttpResponseInfo* response,
- const BoundNetLog& net_log) {
- DCHECK(response->headers.get());
- int rv = auth->HandleAuthChallenge(response->headers, false, true, net_log);
- response->auth_challenge = auth->auth_info();
- if (rv == OK)
- return ERR_PROXY_AUTH_REQUESTED;
- return rv;
-}
-
-// static
void ProxyClientSocket::LogBlockedTunnelResponse(int http_status_code,
bool is_https_proxy) {
if (is_https_proxy) {
@@ -103,9 +91,7 @@ bool ProxyClientSocket::SanitizeProxyAuth(HttpResponseInfo* response) {
CopyHeaderValues(old_headers, new_headers, "trailer");
CopyHeaderValues(old_headers, new_headers, "transfer-encoding");
CopyHeaderValues(old_headers, new_headers, "upgrade");
-
CopyHeaderValues(old_headers, new_headers, "content-length");
-
CopyHeaderValues(old_headers, new_headers, "proxy-authenticate");
response->headers = new_headers;
« no previous file with comments | « net/http/proxy_client_socket.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698