Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: net/http/http_network_transaction.h

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_unittest.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.h
diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h
index a5e5b08032353f7189b89ba61ee5c78ce2b65408..8760eb248ce4dfb7d30d63f3b62f6e96c89d9f9b 100644
--- a/net/http/http_network_transaction.h
+++ b/net/http/http_network_transaction.h
@@ -145,6 +145,8 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
STATE_SEND_REQUEST_COMPLETE,
STATE_READ_HEADERS,
STATE_READ_HEADERS_COMPLETE,
+ STATE_HANDLE_AUTH_CHALLENGE,
+ STATE_HANDLE_AUTH_CHALLENGE_COMPLETE,
STATE_READ_BODY,
STATE_READ_BODY_COMPLETE,
STATE_DRAIN_BODY_FOR_AUTH_RESTART,
@@ -185,6 +187,8 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
int DoSendRequestComplete(int result);
int DoReadHeaders();
int DoReadHeadersComplete(int result);
+ int DoHandleAuthChallenge();
+ int DoHandleAuthChallengeComplete(int result);
int DoReadBody();
int DoReadBodyComplete(int result);
int DoDrainBodyForAuthRestart();
@@ -251,11 +255,6 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
// Returns true if we should try to add an Authorization header.
bool ShouldApplyServerAuth() const;
- // Handles HTTP status code 401 or 407.
- // HandleAuthChallenge() returns a network error code, or OK on success.
- // May update |pending_auth_target_| or |response_.auth_challenge|.
- int HandleAuthChallenge();
-
// Returns true if we have auth credentials for the given target.
bool HaveAuth(HttpAuth::Target target) const;
« no previous file with comments | « net/http/http_auth_unittest.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698