Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Unified Diff: net/http/http_auth_handler_ntlm.cc

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_ntlm.h ('k') | net/http/http_auth_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_ntlm.cc
diff --git a/net/http/http_auth_handler_ntlm.cc b/net/http/http_auth_handler_ntlm.cc
index c866598707f173ecd0e2f687ee8bc86f7c22a11a..7d1367e5f2d7bfc138d9b812328dfe15308094dc 100644
--- a/net/http/http_auth_handler_ntlm.cc
+++ b/net/http/http_auth_handler_ntlm.cc
@@ -21,12 +21,22 @@ HttpAuth::AuthorizationResult HttpAuthHandlerNTLM::HandleAnotherChallenge(
return ParseChallenge(challenge, false);
}
-int HttpAuthHandlerNTLM::Init(const HttpAuthChallengeTokenizer& tok) {
- return ParseChallenge(tok, true) == HttpAuth::AUTHORIZATION_RESULT_ACCEPT
+int HttpAuthHandlerNTLM::InitializeFromChallengeInternal(
+ const HttpAuthChallengeTokenizer& challenge,
+ const HttpResponseInfo& response_with_challenge,
+ const CompletionCallback& callback) {
+ return ParseChallenge(challenge, true) ==
+ HttpAuth::AUTHORIZATION_RESULT_ACCEPT
? OK
: ERR_INVALID_RESPONSE;
}
+int HttpAuthHandlerNTLM::InitializeFromCacheEntryInternal(
+ HttpAuthCache::Entry*) {
+ NOTREACHED();
+ return ERR_UNSUPPORTED_AUTH_SCHEME;
+}
+
int HttpAuthHandlerNTLM::GenerateAuthTokenImpl(
const AuthCredentials* credentials,
const HttpRequestInfo& request,
@@ -145,7 +155,6 @@ std::string HttpAuthHandlerNTLM::CreateSPN(const GURL& origin) {
scoped_ptr<HttpAuthHandler>
HttpAuthHandlerNTLM::Factory::CreateAndInitPreemptiveAuthHandler(
HttpAuthCache::Entry* cache_entry,
- const HttpAuthChallengeTokenizer& tokenizer,
HttpAuth::Target target,
const BoundNetLog& net_log) {
return scoped_ptr<HttpAuthHandler>();
« no previous file with comments | « net/http/http_auth_handler_ntlm.h ('k') | net/http/http_auth_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698