Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: net/http/http_auth_handler_negotiate.cc

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_negotiate.h ('k') | net/http/http_auth_handler_negotiate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate.cc
diff --git a/net/http/http_auth_handler_negotiate.cc b/net/http/http_auth_handler_negotiate.cc
index a183238faf4420704070ed66aa0bff57c7bbaecf..a0fa2dc725ca9533dd676c4a5ff005ee027151ff 100644
--- a/net/http/http_auth_handler_negotiate.cc
+++ b/net/http/http_auth_handler_negotiate.cc
@@ -42,7 +42,6 @@ void HttpAuthHandlerNegotiate::Factory::set_host_resolver(
scoped_ptr<HttpAuthHandler>
HttpAuthHandlerNegotiate::Factory::CreateAndInitPreemptiveAuthHandler(
HttpAuthCache::Entry* cache_entry,
- const HttpAuthChallengeTokenizer& tokenizer,
HttpAuth::Target target,
const BoundNetLog& net_log) {
return scoped_ptr<HttpAuthHandler>();
@@ -195,8 +194,10 @@ bool HttpAuthHandlerNegotiate::AllowsExplicitCredentials() {
// The Negotiate challenge header looks like:
// WWW-Authenticate: NEGOTIATE auth-data
-int HttpAuthHandlerNegotiate::Init(
- const HttpAuthChallengeTokenizer& challenge) {
+int HttpAuthHandlerNegotiate::InitializeFromChallengeInternal(
+ const HttpAuthChallengeTokenizer& challenge,
+ const HttpResponseInfo& response_with_challenge,
+ const CompletionCallback& callback) {
#if defined(OS_POSIX)
if (!auth_system_.Init()) {
VLOG(1) << "can't initialize GSSAPI library";
@@ -219,6 +220,12 @@ int HttpAuthHandlerNegotiate::Init(
: ERR_INVALID_RESPONSE;
}
+int HttpAuthHandlerNegotiate::InitializeFromCacheEntryInternal(
+ HttpAuthCache::Entry*) {
+ NOTREACHED();
+ return ERR_UNSUPPORTED_AUTH_SCHEME;
+}
+
int HttpAuthHandlerNegotiate::GenerateAuthTokenImpl(
const AuthCredentials* credentials,
const HttpRequestInfo& request,
« no previous file with comments | « net/http/http_auth_handler_negotiate.h ('k') | net/http/http_auth_handler_negotiate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698