Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: net/http/http_auth_handler_digest.h

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest.h
diff --git a/net/http/http_auth_handler_digest.h b/net/http/http_auth_handler_digest.h
index 4c5052fb3be784e9e3329e6bb4888c7ae8fa8590..5a3d4165d7e933e498fe09f1b997589bb68bfdf7 100644
--- a/net/http/http_auth_handler_digest.h
+++ b/net/http/http_auth_handler_digest.h
@@ -70,7 +70,6 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
const std::string& scheme) override;
scoped_ptr<HttpAuthHandler> CreateAndInitPreemptiveAuthHandler(
HttpAuthCache::Entry* cache_entry,
- const HttpAuthChallengeTokenizer& tokenizer,
HttpAuth::Target target,
const BoundNetLog& net_log) override;
@@ -78,13 +77,19 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
scoped_ptr<const NonceGenerator> nonce_generator_;
};
+ // HttpAuthHandler
HttpAuth::AuthorizationResult HandleAnotherChallenge(
const HttpAuthChallengeTokenizer& challenge) override;
~HttpAuthHandlerDigest() override;
protected:
- int Init(const HttpAuthChallengeTokenizer& challenge) override;
-
+ // HttpAuthHandler
+ int InitializeFromChallengeInternal(
+ const HttpAuthChallengeTokenizer& challenge,
+ const HttpResponseInfo& response_with_challenge,
+ const CompletionCallback& callback) override;
+ int InitializeFromCacheEntryInternal(
+ HttpAuthCache::Entry* cache_entry) override;
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
const HttpRequestInfo& request,
const CompletionCallback& callback,
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698