Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: net/http/http_auth_handler_basic.h

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_basic.h
diff --git a/net/http/http_auth_handler_basic.h b/net/http/http_auth_handler_basic.h
index af59584310e368478000576098c2d7b0fc2afef8..516fb7f49179658b2d24c94da0cc10495794bea8 100644
--- a/net/http/http_auth_handler_basic.h
+++ b/net/http/http_auth_handler_basic.h
@@ -26,7 +26,6 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {
const std::string& scheme) override;
scoped_ptr<HttpAuthHandler> CreateAndInitPreemptiveAuthHandler(
HttpAuthCache::Entry* cache_entry,
- const HttpAuthChallengeTokenizer& tokenizer,
HttpAuth::Target target,
const BoundNetLog& net_log) override;
};
@@ -39,7 +38,12 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {
protected:
// HttpAuthHandler
- int Init(const HttpAuthChallengeTokenizer& challenge) override;
+ int InitializeFromChallengeInternal(
+ const HttpAuthChallengeTokenizer& challenge,
+ const HttpResponseInfo& response_with_challenge,
+ const CompletionCallback& callback) override;
+ int InitializeFromCacheEntryInternal(
+ HttpAuthCache::Entry* cache_entry) override;
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
const HttpRequestInfo& request,
const CompletionCallback& callback,
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698