Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/http/http_auth.h

Issue 1391053002: [net/http auth] Make HttpAuthHandler challenge handling asynchronous. Base URL: https://chromium.googlesource.com/chromium/src.git@auth-handler-init-split
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth.h
diff --git a/net/http/http_auth.h b/net/http/http_auth.h
index c259cf55c3f3a10bd488b62d05cb596656378a31..a7bb2ab4014d689ee55c5dabde03e79e9144481a 100644
--- a/net/http/http_auth.h
+++ b/net/http/http_auth.h
@@ -93,7 +93,7 @@ class NET_EXPORT_PRIVATE HttpAuth {
~Identity();
IdentitySource source;
- bool invalid;
+ bool invalid; // TODO(asanka): Invert this.
AuthCredentials credentials;
};
@@ -109,52 +109,6 @@ class NET_EXPORT_PRIVATE HttpAuth {
// messages.
static std::string GetAuthTargetString(Target target);
- // Iterate through the challenge headers, and pick the best one that we
- // support. Obtains the implementation class for handling the challenge, and
- // passes it back in |*handler|. If no supported challenge was found,
- // |*handler| is set to NULL.
- //
- // |disabled_schemes| is the set of schemes that we should not use.
- //
- // |origin| is used by the NTLM and Negotiation authentication scheme to
- // construct the service principal name. It is ignored by other schemes.
- static void ChooseBestChallenge(
- HttpAuthHandlerFactory* http_auth_handler_factory,
- const HttpResponseHeaders* headers,
- Target target,
- const GURL& origin,
- const HttpAuthSchemeSet& disabled_schemes,
- const BoundNetLog& net_log,
- scoped_ptr<HttpAuthHandler>* handler);
-
- // Handle a 401/407 response from a server/proxy after a previous
- // authentication attempt. For connection-based authentication schemes, the
- // new response may be another round in a multi-round authentication sequence.
- // For request-based schemes, a 401/407 response is typically treated like a
- // rejection of the previous challenge, except in the Digest case when a
- // "stale" attribute is present.
- //
- // |handler| must be non-NULL, and is the HttpAuthHandler from the previous
- // authentication round.
- //
- // |headers| must be non-NULL and contain the new HTTP response.
- //
- // |target| specifies whether the authentication challenge response came
- // from a server or a proxy.
- //
- // |disabled_schemes| are the authentication schemes to ignore.
- //
- // |challenge_used| is the text of the authentication challenge used in
- // support of the returned AuthorizationResult. If no headers were used for
- // the result (for example, all headers have unknown authentication schemes),
- // the value is cleared.
- static AuthorizationResult HandleChallengeResponse(
- HttpAuthHandler* handler,
- const HttpResponseHeaders* headers,
- Target target,
- const HttpAuthSchemeSet& disabled_schemes,
- std::string* challenge_used);
-
// RFC 7235 states that an authentication scheme is a case insensitive token.
// This function checks whether |scheme| is a token AND is lowercase.
static bool IsValidNormalizedScheme(const std::string& scheme);
« no previous file with comments | « no previous file | net/http/http_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698