Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 139103002: Break out of the loop in QuicSession::OnCanWrite if the QuicConnection (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Break out of the loop in QuicSession::OnCanWrite if the QuicConnection is congestion control blocked. This fixes a weird form of starvation among same-priority streams caused by streams often ending up in the same order in the WriteBlockedList before and after QuicSession::OnCanWrite. Stop iterating through QUIC write blocked streams if the connection is congestion-control blocked to avoid starvation of same-priority streams. Not flag protected. Merge internal change: 59513911 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -7 lines) Patch
M net/quic/quic_connection.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.h View 3 chunks +17 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-15 02:01:20 UTC) #1
Ryan Hamilton
6 years, 11 months ago (2014-01-15 05:23:33 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698